[llvm-bugs] [Bug 48053] New: Apply to 11.x: LLDB fixes for minidumps with breakpad-style text hashing and user-specified sysroots

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=48053

            Bug ID: 48053
           Summary: Apply to 11.x: LLDB fixes for minidumps with
                    breakpad-style text hashing and user-specified
                    sysroots
           Product: new-bugs
           Version: 11.0
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: release blocker
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: JCTremoulet at gmail.com
                CC: htmldeveloper at gmail.com, llvm-bugs at lists.llvm.org

Created attachment 24120
  --> https://bugs.llvm.org/attachment.cgi?id=24120&action=edit
Cherry-pick of 61bfc703c3d with conflicts resolved

Opening minidumps from breakpad with user-specified sysroots is a key scenario
for us, so I'll need to support it downstream on 11.0.1.  I'd like to request
that these changes be included in the upstream 11.0.1 release.

This includes one fix for breakpad-style minidumps:
  https://reviews.llvm.org/D89155 -- [lldb] Minidump: check for .text hash
match with directory

And three fixes for opening minidumps with user-specified sysroots:
  https://reviews.llvm.org/D88099 -- [lldb] Fix GetRemoteSharedModule fallback
logic
  https://reviews.llvm.org/D89155 -- [lldb] Minidump: check for .text hash
match with directory
  https://reviews.llvm.org/D89157 -- [lldb] Report old modules from
ModuleList::ReplaceEquivalent

As well as one fix that was needed for a new testcase added in one of the above
commits, to get that test passing on Windows:
 4a55c98fa7b -- [lldb] Normalize paths in new test

Plus one refactoring that one of the above depends on:
  https://reviews.llvm.org/D89156 -- [lldb] GetSharedModule: Collect old
modules in SmallVector

The refactoring doesn't apply cleanly to the 11.x branch, so I'm attaching a
patch file that has it applied with conflicts resolved.


I've verified that the following script applies all of these cleanly to the
11.x branch (as of 8fc424f26b), and passes check-lldb:

---------
    git cherry-pick 20f84257ac4 # https://reviews.llvm.org/D88099 -- [lldb] Fix
GetRemoteSharedModule fallback logic
    git cherry-pick 4a55c98fa7b # (Fix test bug from D88099 for Windows build
bot) -- [lldb] Normalize paths in new test
    git cherry-pick 0e6c9a6e794 # https://reviews.llvm.org/D86261-- Add hashing
of the .text section to ProcessMinidump.
    git cherry-pick d30797b4041 # https://reviews.llvm.org/D89155 -- [lldb]
Minidump: check for .text hash match with directory

    # Next we need 61bfc703c3d # https://reviews.llvm.org/D89156 -- [lldb]
GetSharedModule: Collect old modules in SmallVector
    # but it doesn't cherry-pick cleanly, so apply the patch attached to the
bug, which has the change but
    # with conflicts resolved.
    git apply --index pick-61bfc703c3d-resolved.txt
    git commit --reuse-message=61bfc703c3d

    git cherry-pick d20aa7ca422 # https://reviews.llvm.org/D89157 -- [lldb]
Report old modules from ModuleList::ReplaceEquivalent
---------

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20201102/e35ab2c8/attachment.html>