[llvm-bugs] [Bug 46465] New: libcxx/src/CMakeLists.txt includes thread_win32.cpp regardless of LIBCXX_HAS_WIN32_THREAD_API

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=46465

            Bug ID: 46465
           Summary: libcxx/src/CMakeLists.txt includes thread_win32.cpp
                    regardless of LIBCXX_HAS_WIN32_THREAD_API
           Product: libc++
           Version: 10.0
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: unassignedclangbugs at nondot.org
          Reporter: usaonmonday at gmail.com
                CC: llvm-bugs at lists.llvm.org, mclow.lists at gmail.com

libcxx/src/CMakeLists.txt has the following fragment:

if(WIN32)
  list(APPEND LIBCXX_SOURCES
    support/win32/locale_win32.cpp
    support/win32/support.cpp
    support/win32/thread_win32.cpp
    )

If LIBCXX_HAS_PTHREAD_API is ON and LIBCXX_HAS_WIN32_THREAD_API is OFF (MINGW),
this causes linker errors.

It should be:

if(WIN32)
  list(APPEND LIBCXX_SOURCES
    support/win32/locale_win32.cpp
    support/win32/support.cpp
    )
  if (LIBCXX_HAS_WIN32_THREAD_API)
    list(APPEND LIBCXX_SOURCES
      support/win32/thread_win32.cpp
      )
  endif()

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200626/3689cdcf/attachment.html>