[llvm-bugs] [Bug 44696] New: ClangdTests.exe/Hover.All fail on 32-bit windows

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=44696

            Bug ID: 44696
           Summary: ClangdTests.exe/Hover.All fail on 32-bit windows
           Product: new-bugs
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: hans at chromium.org
                CC: htmldeveloper at gmail.com,
                    kadircetinkaya.06.tr at gmail.com,
                    llvm-bugs at lists.llvm.org
            Blocks: 44555

The problem is that member functions have __attribute__((thiscall)) in the AST
when targeting 32-bit Windows, and the test doesn't expect that.

I wasn't sure how to fix that. Alternatively, maybe the test could have a
target triple so that the AST doesn't vary between host platforms?



[2044/2045] Running the Clangd regression tests
llvm-lit.py: C:/src/llvm.monorepo/llvm\utils\lit\lit\llvm\config.py:342: note:
using clang: c:\src\llvm.monorepo\build.32_2019\bin\clang.exe
-- Testing: 724 tests, 32 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
FAIL: Clangd Unit Tests :: ./ClangdTests.exe/Hover.All (723 of 724)
******************** TEST 'Clangd Unit Tests :: ./ClangdTests.exe/Hover.All'
FAILED ********************
Note: Google Test filter = Hover.All
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from Hover
[ RUN      ] Hover.All
C:\src\llvm.monorepo\clang-tools-extra\clangd\unittests\HoverTests.cpp(1628):
error:       Expected: H->Type
      Which is: int () __attribute__((thiscall))
To be equal to: Expected.Type
      Which is: int ()
Google Test trace:
C:\src\llvm.monorepo\clang-tools-extra\clangd\unittests\HoverTests.cpp(1621):
instance-method x

→ int

// In Foo
int x()
C:\src\llvm.monorepo\clang-tools-extra\clangd\unittests\HoverTests.cpp(1604):
// Method call
            struct Foo { int x(); };
            int main() {
              Foo bar;
              bar.^[[x]]();
            }

C:\src\llvm.monorepo\clang-tools-extra\clangd\unittests\HoverTests.cpp(1628):
error:       Expected: H->Type
      Which is: int () __attribute__((thiscall))
To be equal to: Expected.Type
      Which is: int ()
Google Test trace:
C:\src\llvm.monorepo\clang-tools-extra\clangd\unittests\HoverTests.cpp(1621):
instance-method method

→ int

// In cls<int>
int method()
C:\src\llvm.monorepo\clang-tools-extra\clangd\unittests\HoverTests.cpp(1604):
// should not crash.
          template <class T> struct cls {
            int method();
          };

          auto test = cls<int>().[[m^ethod]]();

[  FAILED  ] Hover.All (959 ms)
[----------] 1 test from Hover (959 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (959 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] Hover.All

 1 FAILED TEST
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213812 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213900 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213904 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp
Building first preamble for C:\clangd-test\TestTU.cpp
Built preamble of size 213704 for file C:\clangd-test\TestTU.cpp

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

Testing Time: 5.27s
********************
Failing Tests (1):
    Clangd Unit Tests :: ./ClangdTests.exe/Hover.All

  Expected Passes    : 715
  Unsupported Tests  : 8
  Unexpected Failures: 1
FAILED: tools/clang/tools/extra/clangd/test/CMakeFiles/check-clangd
cmd.exe /C "cd /D
C:\src\llvm.monorepo\build.32_2019\tools\clang\tools\extra\clangd\test &&
C:\python_27_amd64\files\python.exe
C:/src/llvm.monorepo/build.32_2019/./bin/llvm-lit.py -sv
C:/src/llvm.monorepo/build.32_2019/tools/clang/tools/extra/clangd/test/../unittests
C:/src/llvm.monorepo/build.32_2019/tools/clang/tools/extra/clangd/test"
ninja: build stopped: subcommand failed.


Referenced Bugs:

https://bugs.llvm.org/show_bug.cgi?id=44555
[Bug 44555] [meta] 10.0.0 Release Blockers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200128/66e2cdd3/attachment-0001.html>