[llvm-bugs] [Bug 44320] SSAUpdater corrupts SCEV

via llvm-bugs llvm-bugs at lists.llvm.org
Thu Jan 23 01:14:17 PST 2020


Daniil Suchkov <suc-daniil at yandex.ru> changed:

           What    |Removed                     |Added
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #5 from Daniil Suchkov <suc-daniil at yandex.ru> ---
Fixed by:
commit 4a8dbc617d0b28ce2ce3e6856376b3802409554e
Author: Daniil Suchkov <suc-daniil at yandex.ru>
Date:   Tue Jan 21 12:21:53 2020 +0700

[SSAUpdater] Don't call ValueIsRAUWd upon single use replacement

It is incorrect to call ValueHandleBase::ValueIsRAUWd when only one use
is replaced since it simply violates semantics of the callback and leads
to bugs like PR44320.

Previously this call was used specifically to keep LICM's cache of
AliasSetTrackers up to date across passes (as PR36801 showed, even for
that purpose it didn't work properly), but since LICM doesn't have that
cache anymore, we can safely remove this incorrect call with no

This patch fixes https://bugs.llvm.org/show_bug.cgi?id=44320

Reviewers: asbirlea, fhahn, efriedma, reames

Reviewed-By: asbirlea

Differential Revision: https://reviews.llvm.org/D73089

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200123/3f38a7d2/attachment.html>

More information about the llvm-bugs mailing list