[llvm-bugs] [Bug 45057] New: Interface return type incorrectly placed on separate line when it is annotated with a long annotation

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=45057

            Bug ID: 45057
           Summary: Interface return type incorrectly placed on separate
                    line when it is annotated with a long annotation
           Product: clang
           Version: 9.0
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Formatter
          Assignee: unassignedclangbugs at nondot.org
          Reporter: nikolaos.georgiou at gmail.com
                CC: djasper at google.com, klimek at google.com,
                    llvm-bugs at lists.llvm.org

Consider the following Java code:

```
public interface ThingsDao {                                                    

    @SqlUpdate(                                                                 
        "UPDATE things SET score=:score, comments=:comments,
last_modified_at=:lastModifiedAt, "                   
        + "last_checked_at=:lastCheckedAt WHERE id=:id")                        
    void update(                                                                
        @Bind("score") int score,                                               
        @Bind("comments") int comments,                                         
        @Bind("lastModifiedAt") LocalDateTime lastModifiedAt,                   
        @Bind("lastCheckedAt") LocalDateTime lastCheckedAt,                     
        @Bind("id") long id);                                                   

    @SqlUpdate("UPDATE things SET last_checked_at=:lastCheckedAt WHERE id=:id") 
    void update(@Bind("lastCheckedAt") LocalDateTime lastCheckedAt, @Bind("id")
long id);                          
}                                                                               
```

Both methods are annotated with the same annotation, but the first one has a
long annotation which needs to be broken down into multiple lines.

When using clang-format, the long annotation seems to confuse it, as the first
method puts the return type `void` in a separate line. This does not happen for
the second method.

This is the diff:

```
     @SqlUpdate(
         "UPDATE things SET score=:score, comments=:comments,
last_modified_at=:lastModifiedAt, "
         + "last_checked_at=:lastCheckedAt WHERE id=:id")
-    void update(
+    void
+    update(
         @Bind("score") int score,
         @Bind("comments") int comments,
         @Bind("lastModifiedAt") LocalDateTime lastModifiedAt,
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200228/1d139320/attachment-0001.html>