[llvm-bugs] [Bug 48494] New: ARM64 outline atomic helpers are built using the C compiler

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=48494

            Bug ID: 48494
           Summary: ARM64 outline atomic helpers are built using the C
                    compiler
           Product: compiler-rt
           Version: unspecified
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: release blocker
          Priority: P
         Component: builtins
          Assignee: pavel.iliin at arm.com
          Reporter: raul at tambre.ee
                CC: llvm-bugs at lists.llvm.org

Assembly files should not be compiled as C and instead use CMake's assembly
language support to allow for vendors and users to specify flags, compiler
options, use a different executable, have correct architecture flags, interact
properly with toolchain files, etc.

The compiler-rt ARM64 outline atomic helpers are a new and the only case of
this improper usage in the codebase.
It seems these should use the already-existing compiler-rt add_asm_sources()
helper.

Previous occurrences of this were fixed by
https://github.com/llvm/llvm-project/commit/45344cf7ac5b848f77825ffa37b0cb3b69b9b07b.
The improper usage resulted in multiple reports from users and vendors,
requiring a backport to resolve build issues.
It would be best to avoid a recurrence of the problems. Marking as a release
blocker due to this.

Pavel, could you take a look at this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20201212/c9737e2b/attachment.html>