[llvm-bugs] [Bug 43412] New: [MIPS][LLD][FreeBSD] n32 abi check fails with osabi included

via llvm-bugs llvm-bugs at lists.llvm.org
Mon Sep 23 09:11:00 PDT 2019


https://bugs.llvm.org/show_bug.cgi?id=43412

            Bug ID: 43412
           Summary: [MIPS][LLD][FreeBSD] n32 abi check fails with osabi
                    included
           Product: new-bugs
           Version: unspecified
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: kevans at FreeBSD.org
                CC: htmldeveloper at gmail.com, llvm-bugs at lists.llvm.org

Created attachment 22546
  --> https://bugs.llvm.org/attachment.cgi?id=22546&action=edit
git(1) diff against our contrib tree

FreeBSD will include '_fbsd' at the end (e.g. "elf32btsmipn32_fbsd") to
indicate osabi in the emulation string. The later mipsN32Abi check compares the
emulation string directly to elf32btsmipn32 and thus, it doesn't get recognized
as N32 ABI.

The attached patch changes these to use StringRef.startsWith since the
emulation strings we're checking for are unique enough that this is OK. It was
unclear to me if we should instead be stripping off the osabi indicator after
it's used, but it doesn't seem to get used much so I opted for this instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20190923/d659a070/attachment-0001.html>


More information about the llvm-bugs mailing list