[llvm-bugs] [Bug 43196] New: Please backport r369310 to 9.x

via llvm-bugs llvm-bugs at lists.llvm.org
Mon Sep 2 08:38:06 PDT 2019


            Bug ID: 43196
           Summary: Please backport r369310 to 9.x
           Product: new-bugs
           Version: 9.0
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: mgorny at gentoo.org
                CC: htmldeveloper at gmail.com, llvm-bugs at lists.llvm.org
            Blocks: 42474

While the commit in question is marked as 'NFC', without it the following tests
hang for me on NetBSD:

    LLVM :: ExecutionEngine/MCJIT/eh-lg-pic.ll
    LLVM :: ExecutionEngine/MCJIT/eh.ll
    LLVM :: ExecutionEngine/MCJIT/multi-module-eh-a.ll
    LLVM :: ExecutionEngine/OrcMCJIT/eh-lg-pic.ll
    LLVM :: ExecutionEngine/OrcMCJIT/eh.ll
    LLVM :: ExecutionEngine/OrcMCJIT/multi-module-eh-a.ll

To be honest, I don't know how it is relevant.  It is possible that the linking
is necessary for reasons other than those listed in the commit message.

commit 949113e632cf531019f121a27c9725abc65daa56
Author: Hubert Tong <hubert.reinterpretcast at gmail.com>
Date:   Mon Aug 19 23:12:48 2019 +0000

    [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC

    rL367756 (f5c40cb) increases the dependency of LLVMOrcJIT on LLVMPasses.    
    In particular, symbols defined in LLVMPasses that are referenced by the     
    destructor of `PassBuilder` are now referenced by LLVMOrcJIT through

    We believe that referencing symbols defined in LLVMPasses in the
    destructor of `PassBuilder` is valid, and that adding to the set of such    
    symbols is legitimate. To support such cases, this patch adds LLVMPasses    
    to the set of libraries being linked when linking in LLVMOrcJIT causes      
    such symbols from LLVMPasses to be referenced.

    Reviewers: Whitney, anhtuyen, pree-jackie

    Reviewed By: pree-jackie

    Subscribers: mgorny, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D66441

    llvm-svn: 369310

Referenced Bugs:

[Bug 42474] [meta] 9.0.0 Release Blockers
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20190902/0e23d286/attachment.html>

More information about the llvm-bugs mailing list