[llvm-bugs] [Bug 41155] New: dsymutil prints needless "Warning: request a ThreadPool with 1 threads, but LLVM_ENABLE_THREADS has been turned off" with LLVM_ENABLE_THREADS=OFF

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=41155

            Bug ID: 41155
           Summary: dsymutil prints needless "Warning: request a
                    ThreadPool with 1 threads, but LLVM_ENABLE_THREADS has
                    been turned off" with LLVM_ENABLE_THREADS=OFF
           Product: tools
           Version: trunk
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: llvm-dsymutil
          Assignee: unassignedbugs at nondot.org
          Reporter: nicolasweber at gmx.de
                CC: aprantl at apple.com, friss at apple.com,
                    jdevlieghere at apple.com, llvm-bugs at lists.llvm.org

We (mostly accidentally) built dsymutil with LLVM_ENABLE_THREADS=OFF. Since we
don't have any fat binaries, dsymutil defaults to using a thread pool with 1
thread, so there isn't a performance hit from this.


I can see why llvm's thread pool warns if the thread count is > 0 not > 1 (what
if the thread owning the pool does any work other than .Wait() – this might
even be a deadlock), but maybe it should have a setting that tells it to only
warn on > 1 threads, or dsymutil could check for LLVM_ENABLE_THREADS=OFF
directly.




(Also, dsymutil currently calls llvm::thread::hardware_concurrency() when it
should call llvm::hardware_concurrency() -- I think the former form calls the
stdlib method instead of the wrapper in llvm that handles
LLVM_ENABLE_THREADS=OFF.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20190320/22b9314f/attachment.html>