[llvm-bugs] [Bug 40244] New: Tidy up llvm-ar's error messages

via llvm-bugs llvm-bugs at lists.llvm.org
Mon Jan 7 07:54:14 PST 2019


            Bug ID: 40244
           Summary: Tidy up llvm-ar's error messages
           Product: tools
           Version: trunk
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P
         Component: llvm-ar
          Assignee: unassignedbugs at nondot.org
          Reporter: jh7370.2008 at my.bristol.ac.uk
                CC: llvm-bugs at lists.llvm.org

llvm-ar is not very consistent in some of its error messages, and in some cases
produces output that is not syntactically correct (i.e. extra new lines,
spurious trailing fullstops and exclamation marks, that sort of thing).

For example, the performOperation function has a call to fail() and two to
failIfError(). In two out of three of these calls, the message passed into the
function is a local error message, with std::error_code::message() appeneded,
followed by an exclamation mark. The latter prints a full stop and new line (at
least on my version of Windows). fail and failIfError themselves also append
".\n", so you end up with an error message that looks something like the

error: some text: the error message.

Which is obviously needs a bit of improvement. These were the only cases with
issues that I found with a quick glance, but there could be others.

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20190107/18faf015/attachment.html>

More information about the llvm-bugs mailing list