[llvm-bugs] [Bug 31774] LLVM generates poor code for MSVC std::string::~string due to memalign-like code in std::allocator<T>::deallocate

via llvm-bugs llvm-bugs at lists.llvm.org
Tue Oct 30 16:18:10 PDT 2018


https://bugs.llvm.org/show_bug.cgi?id=31774

Reid Kleckner <rnk at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Reid Kleckner <rnk at google.com> ---
r295105 improved the situation here a lot by merging such blocks during
codegen.

Also, new STL versions have improved the situation a lot. They only have one
abort call now.

I abandoned my attempts to do this in the IR, since I didn't get good perf
results from self-hosting clang with assertions enabled. I seem to have lost
the patch and results from that effort, which is unfortunate.

I think it's reasonable to mark this "fixed" with the MSVC STL changes and our
codegen changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20181030/326b2396/attachment.html>


More information about the llvm-bugs mailing list