<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:rnk@google.com" title="Reid Kleckner <rnk@google.com>"> <span class="fn">Reid Kleckner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - LLVM generates poor code for MSVC std::string::~string due to memalign-like code in std::allocator<T>::deallocate"
href="https://bugs.llvm.org/show_bug.cgi?id=31774">bug 31774</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - LLVM generates poor code for MSVC std::string::~string due to memalign-like code in std::allocator<T>::deallocate"
href="https://bugs.llvm.org/show_bug.cgi?id=31774#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - LLVM generates poor code for MSVC std::string::~string due to memalign-like code in std::allocator<T>::deallocate"
href="https://bugs.llvm.org/show_bug.cgi?id=31774">bug 31774</a>
from <span class="vcard"><a class="email" href="mailto:rnk@google.com" title="Reid Kleckner <rnk@google.com>"> <span class="fn">Reid Kleckner</span></a>
</span></b>
<pre>r295105 improved the situation here a lot by merging such blocks during
codegen.
Also, new STL versions have improved the situation a lot. They only have one
abort call now.
I abandoned my attempts to do this in the IR, since I didn't get good perf
results from self-hosting clang with assertions enabled. I seem to have lost
the patch and results from that effort, which is unfortunate.
I think it's reasonable to mark this "fixed" with the MSVC STL changes and our
codegen changes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>