[llvm-bugs] [Bug 24653] New: Test log-path_test.cc fails in Windows native environment

[via llvm-bugs]

https://llvm.org/bugs/show_bug.cgi?id=24653

            Bug ID: 24653
           Summary: Test log-path_test.cc fails in Windows native
                    environment
           Product: compiler-rt
           Version: 3.7
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P
         Component: compiler-rt
          Assignee: unassignedbugs at nondot.org
          Reporter: vera.fedorova at intel.com
                CC: llvm-bugs at lists.llvm.org
    Classification: Unclassified

Test coverage-levels.cc fails in Windows native environment after changing
(r245967 | samsonov: Introduce %env_ubsan_opts= substitution) due to incorrent
syntax.


// RUN: %env_ubsan_opts=log_path='"%t.log"' %run %t -4 2> %t.out
// RUN: %env_ubsan_opts=log_path='"%t.log"'  %run %t 4


On Windows symbols ' become a part of the log_path, it leds to file access
error.

Using '-symbols :
C:\Users\buildbot>set MY_TEMP='"c:\temp"'
C:\Users\buildbot>set | findstr MY_TEMP
MY_TEMP='"c:\temp"'

C:\Users\buildbot>dir %MY_TEMP%
The filename, directory name, or volume label syntax is incorrect.

Without '-symbols :
C:\Users\buildbot>set MY_TEMP="c:\temp"
C:\Users\buildbot>set | findstr MY_TEMP
MY_TEMP="c:\temp"

C:\Users\buildbot>dir %MY_TEMP%
 Volume is drive C <...>


Proposed change:

Index: llvm/projects/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cc
===================================================================
--- llvm/projects/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cc
(revision 246546)
+++ llvm/projects/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cc
(working copy)
@@ -9,12 +9,12 @@

 // Good log_path.
 // RUN: rm -f %t.log.*
-// RUN: %env_ubsan_opts=log_path='"%t.log"' %run %t -4 2> %t.out
+// RUN: %env_ubsan_opts=log_path="%t.log" %run %t -4 2> %t.out
 // RUN: FileCheck %s --check-prefix=CHECK-ERROR < %t.log.*

 // Run w/o errors should not produce any log.
 // RUN: rm -f %t.log.*
-// RUN: %env_ubsan_opts=log_path='"%t.log"'  %run %t 4
+// RUN: %env_ubsan_opts=log_path="%t.log"  %run %t 4
 // RUN: not cat %t.log.*

 // FIXME: log_path is not supported on Windows yet.


This problem affects Windows native buildbot
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7. 


Vera Fedorova
===================
Software Engineer
Intel Compiler Team
Intel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20150901/fc1414b3/attachment-0001.html>