<html>
    <head>
      <base href="https://llvm.org/bugs/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - Test log-path_test.cc fails in Windows native environment"
   href="https://llvm.org/bugs/show_bug.cgi?id=24653">24653</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Test log-path_test.cc fails in Windows native environment
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>compiler-rt
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>3.7
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Windows NT
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>compiler-rt
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>vera.fedorova@intel.com
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvm-bugs@lists.llvm.org
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Test coverage-levels.cc fails in Windows native environment after changing
(r245967 | samsonov: Introduce %env_ubsan_opts= substitution) due to incorrent
syntax.


// RUN: %env_ubsan_opts=log_path='"%t.log"' %run %t -4 2> %t.out
// RUN: %env_ubsan_opts=log_path='"%t.log"'  %run %t 4


On Windows symbols ' become a part of the log_path, it leds to file access
error.

Using '-symbols :
C:\Users\buildbot>set MY_TEMP='"c:\temp"'
C:\Users\buildbot>set | findstr MY_TEMP
MY_TEMP='"c:\temp"'

C:\Users\buildbot>dir %MY_TEMP%
The filename, directory name, or volume label syntax is incorrect.

Without '-symbols :
C:\Users\buildbot>set MY_TEMP="c:\temp"
C:\Users\buildbot>set | findstr MY_TEMP
MY_TEMP="c:\temp"

C:\Users\buildbot>dir %MY_TEMP%
 Volume is drive C <...>


Proposed change:

Index: llvm/projects/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cc
===================================================================
--- llvm/projects/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cc
(revision 246546)
+++ llvm/projects/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cc
(working copy)
@@ -9,12 +9,12 @@

 // Good log_path.
 // RUN: rm -f %t.log.*
-// RUN: %env_ubsan_opts=log_path='"%t.log"' %run %t -4 2> %t.out
+// RUN: %env_ubsan_opts=log_path="%t.log" %run %t -4 2> %t.out
 // RUN: FileCheck %s --check-prefix=CHECK-ERROR < %t.log.*

 // Run w/o errors should not produce any log.
 // RUN: rm -f %t.log.*
-// RUN: %env_ubsan_opts=log_path='"%t.log"'  %run %t 4
+// RUN: %env_ubsan_opts=log_path="%t.log"  %run %t 4
 // RUN: not cat %t.log.*

 // FIXME: log_path is not supported on Windows yet.


This problem affects Windows native buildbot
<a href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7">http://lab.llvm.org:8011/builders/clang-x64-ninja-win7</a>. 


Vera Fedorova
===================
Software Engineer
Intel Compiler Team
Intel</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>