[llvm-bugs] [Bug 25368] Namespace lost in modules

via llvm-bugs llvm-bugs at lists.llvm.org
Thu Nov 5 13:17:10 PST 2015


https://llvm.org/bugs/show_bug.cgi?id=25368

Richard Smith <richard-llvm at metafoo.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Richard Smith <richard-llvm at metafoo.co.uk> ---
This is also working as intended, and it turns out that this is not a modules
bug at all; the modules build successfully found an error in our code that we
just happened to be getting away with =)

The "using llvm::isa;" in Basic_LLVM.h only makes the /currently-declared/
llvm::isa declarations visible in namespace clang. When building Basic_LLVM as
a module, the only such declaration is the one from Casting.

So the bug is in lib/CodeGen/Address.h; it doesn't push its llvm::isa and
llvm::cast functions into namespace clang.

I've replaced the r251713 workaround with a fix in r252211.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20151105/8c7f529a/attachment-0001.html>


More information about the llvm-bugs mailing list