<html>
    <head>
      <base href="https://llvm.org/bugs/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:richard-llvm@metafoo.co.uk" title="Richard Smith <richard-llvm@metafoo.co.uk>"> <span class="fn">Richard Smith</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Namespace lost in modules"
   href="https://llvm.org/bugs/show_bug.cgi?id=25368">bug 25368</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Status</td>
           <td>REOPENED
           </td>
           <td>RESOLVED
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Resolution</td>
           <td>---
           </td>
           <td>FIXED
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Namespace lost in modules"
   href="https://llvm.org/bugs/show_bug.cgi?id=25368#c10">Comment # 10</a>
              on <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Namespace lost in modules"
   href="https://llvm.org/bugs/show_bug.cgi?id=25368">bug 25368</a>
              from <span class="vcard"><a class="email" href="mailto:richard-llvm@metafoo.co.uk" title="Richard Smith <richard-llvm@metafoo.co.uk>"> <span class="fn">Richard Smith</span></a>
</span></b>
        <pre>This is also working as intended, and it turns out that this is not a modules
bug at all; the modules build successfully found an error in our code that we
just happened to be getting away with =)

The "using llvm::isa;" in Basic_LLVM.h only makes the /currently-declared/
llvm::isa declarations visible in namespace clang. When building Basic_LLVM as
a module, the only such declaration is the one from Casting.

So the bug is in lib/CodeGen/Address.h; it doesn't push its llvm::isa and
llvm::cast functions into namespace clang.

I've replaced the r251713 workaround with a fix in r252211.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>