[llvm-bugs] [Bug 24510] New: Phabricator produces broken patches when the patches include file moves

[via llvm-bugs]

https://llvm.org/bugs/show_bug.cgi?id=24510

            Bug ID: 24510
           Summary: Phabricator produces broken patches when the patches
                    include file moves
           Product: new-bugs
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: dexonsmith at apple.com
                CC: chandlerc at gmail.com, llvm-bugs at lists.llvm.org
    Classification: Unclassified

Created attachment 14749
  --> https://llvm.org/bugs/attachment.cgi?id=14749&action=edit
broken patch from phabricator

D12133 (must be a URL for that somewhere) has a broken patch; Chandler suspects
the cause is something to do with the "diff-construction logic that we added to
make inline comments look right".

Here's what I get when applying the attached patch to r245506:
--
$ patch -p0 <
/Users/dexonsmith/Library/Containers/com.apple.mail/Data/Library/Mail\
Downloads/0174B486-F815-4954-A249-F6C6DF1D10CD/D12133.32497.patch 
patching file lib/Transforms/ObjCARC/PtrState.h
patching file lib/Transforms/ObjCARC/ObjCARCOpts.cpp
patching file lib/Transforms/ObjCARC/CMakeLists.txt
can't find file to patch at input line 52
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: lib/Analysis/ObjCARCInstKind.cpp
|===================================================================
|--- lib/Analysis/ObjCARCInstKind.cpp
|+++ lib/Analysis/ObjCARCInstKind.cpp
--------------------------
File to patch: 
--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20150819/39fc95ee/attachment.html>