<html>
<head>
<base href="https://llvm.org/bugs/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Phabricator produces broken patches when the patches include file moves"
href="https://llvm.org/bugs/show_bug.cgi?id=24510">24510</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Phabricator produces broken patches when the patches include file moves
</td>
</tr>
<tr>
<th>Product</th>
<td>new-bugs
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>new bugs
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dexonsmith@apple.com
</td>
</tr>
<tr>
<th>CC</th>
<td>chandlerc@gmail.com, llvm-bugs@lists.llvm.org
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=14749" name="attach_14749" title="broken patch from phabricator">attachment 14749</a> <a href="attachment.cgi?id=14749&action=edit" title="broken patch from phabricator">[details]</a></span>
broken patch from phabricator
D12133 (must be a URL for that somewhere) has a broken patch; Chandler suspects
the cause is something to do with the "diff-construction logic that we added to
make inline comments look right".
Here's what I get when applying the attached patch to r245506:
--
$ patch -p0 <
/Users/dexonsmith/Library/Containers/com.apple.mail/Data/Library/Mail\
Downloads/0174B486-F815-4954-A249-F6C6DF1D10CD/D12133.32497.patch
patching file lib/Transforms/ObjCARC/PtrState.h
patching file lib/Transforms/ObjCARC/ObjCARCOpts.cpp
patching file lib/Transforms/ObjCARC/CMakeLists.txt
can't find file to patch at input line 52
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: lib/Analysis/ObjCARCInstKind.cpp
|===================================================================
|--- lib/Analysis/ObjCARCInstKind.cpp
|+++ lib/Analysis/ObjCARCInstKind.cpp
--------------------------
File to patch:
--</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>