[LLVMbugs] [Bug 23199] New: Discriminators are added to the line table more often than necessary

[bugzilla-daemon at llvm.org]

https://llvm.org/bugs/show_bug.cgi?id=23199

            Bug ID: 23199
           Summary: Discriminators are added to the line table more often
                    than necessary
           Product: libraries
           Version: trunk
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: DebugInfo
          Assignee: unassignedbugs at nondot.org
          Reporter: dexonsmith at apple.com
                CC: aprantl at apple.com, dblaikie at gmail.com,
                    dnovillo at google.com, echristo at gmail.com,
                    friss at apple.com, llvmbugs at cs.uiuc.edu
    Classification: Unclassified

As discussed on the list [1], we add discriminators to line table entries more
often than necessary.  There may be some downstream users (e.g., Linux perf)
depending on the weak checks -- they should be fixed, and then we should fix
our code to only add discriminators when the entries can't already be
discriminated.

Currently, we check:

  - filename
  - line

We should also check:

  - column
  - discriminator
  - directory

I'll add FIXMEs to the code and mention this PR when I transition the current
functionality from DILocation over to MDLocation.

[1]:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150406/270650.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20150410/61366bdd/attachment.html>