<html>
    <head>
      <base href="https://llvm.org/bugs/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - Discriminators are added to the line table more often than necessary"
   href="https://llvm.org/bugs/show_bug.cgi?id=23199">23199</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Discriminators are added to the line table more often than necessary
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>libraries
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>trunk
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>DebugInfo
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>dexonsmith@apple.com
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>aprantl@apple.com, dblaikie@gmail.com, dnovillo@google.com, echristo@gmail.com, friss@apple.com, llvmbugs@cs.uiuc.edu
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr></table>
      <p>
        <div>
        <pre>As discussed on the list [1], we add discriminators to line table entries more
often than necessary.  There may be some downstream users (e.g., Linux perf)
depending on the weak checks -- they should be fixed, and then we should fix
our code to only add discriminators when the entries can't already be
discriminated.

Currently, we check:

  - filename
  - line

We should also check:

  - column
  - discriminator
  - directory

I'll add FIXMEs to the code and mention this PR when I transition the current
functionality from DILocation over to MDLocation.

[1]:
<a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150406/270650.html">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150406/270650.html</a></pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>