[LLVMbugs] [Bug 17316] New: Respect -fdiagnostics-format when emitting include stack

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=17316

            Bug ID: 17316
           Summary: Respect -fdiagnostics-format when emitting include
                    stack
           Product: new-bugs
           Version: trunk
          Hardware: PC
                OS: other
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: p_hampson at wargaming.net
                CC: llvmbugs at cs.uiuc.edu
    Classification: Unclassified

Created attachment 11256
  --> http://llvm.org/bugs/attachment.cgi?id=11256&action=edit
Add line numbers to all the tests which currently match TextDiagnostic's
filename/line number outputs.

Currently, clang with -fdiagnostics-format=msvc outputs things like this:

included from sourcefile.c:36
header.h(2,7) : warning: extra tokens at end of #endif directive
[-Wextra-tokens]

This means only the line with the error is double-clickable in the MSVC IDE,
not the including line.

I've added code to fix this by adding TextDiagnostic::emitFileReference with
the existing code from the error-emitting method, and calling it from the other
places that emit filename/line number references, except the fixit code, as
that appears to be a specific parsable format.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20130921/90bc3737/attachment.html>