<html>
    <head>
      <base href="http://llvm.org/bugs/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - Respect -fdiagnostics-format when emitting include stack"
   href="http://llvm.org/bugs/show_bug.cgi?id=17316">17316</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Respect -fdiagnostics-format when emitting include stack
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>new-bugs
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>trunk
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>other
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>enhancement
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>new bugs
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>p_hampson@wargaming.net
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvmbugs@cs.uiuc.edu
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=11256" name="attach_11256" title="Add line numbers to all the tests which currently match TextDiagnostic's filename/line number outputs.">attachment 11256</a> <a href="attachment.cgi?id=11256&action=edit" title="Add line numbers to all the tests which currently match TextDiagnostic's filename/line number outputs.">[details]</a></span>
Add line numbers to all the tests which currently match TextDiagnostic's
filename/line number outputs.

Currently, clang with -fdiagnostics-format=msvc outputs things like this:

included from sourcefile.c:36
header.h(2,7) : warning: extra tokens at end of #endif directive
[-Wextra-tokens]

This means only the line with the error is double-clickable in the MSVC IDE,
not the including line.

I've added code to fix this by adding TextDiagnostic::emitFileReference with
the existing code from the error-emitting method, and calling it from the other
places that emit filename/line number references, except the fixit code, as
that appears to be a specific parsable format.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>