[LLVMbugs] [Bug 14007] New: Tests for GCC version are wrong

[bugzilla-daemon at llvm.org]

http://llvm.org/bugs/show_bug.cgi?id=14007

             Bug #: 14007
           Summary: Tests for GCC version are wrong
           Product: libc++
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
        AssignedTo: hhinnant at apple.com
        ReportedBy: holgerar at gmail.com
                CC: llvmbugs at cs.uiuc.edu
    Classification: Unclassified


The file "include/__config" contains tests for the GCC version that look like
this:

  #if !(__GNUC__ >= 4 && __GNUC_MINOR__ >= 3)
  ...
  #endif

This test will fail for a (hypothetical) GCC version >= 5.x.   Assuming the
feature set of GCC to be monotonic, the correct way to write this test is:

  #if !((__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 3)))
  ...
  #endif

-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.