[LLVMbugs] Patch for Win32/MSVC compilation

[Argiris Kirtzidis]

Hi,

'PCSTR' is defined as "CONST CHAR *" and is needed only when compiling 
with VS 2008.
I've corrected the patch (new one attached).


Anton Korobeynikov wrote:
> Hello, Argiris
>
>   
>> +#ifdef _MSC_VER
>> +// Get std::equal_to
>> +#include <functional>
>> +#endif
>>     
> Please, no compiler-specific defines outside libSystem / libSupport.
> Most probably, we should pull <functional> unconditionally here, since
> std::equal_to should be defined there according to standard.
>
>   
>> +  static BOOL CALLBACK ELM_Callback(
>> +#ifdef __MINGW32__
>> +									PSTR  ModuleName,
>> +#else
>> +									PCSTR  ModuleName,
>> +#endif
>>                                      ModuleBaseType ModuleBase,
>>                                      ULONG ModuleSize,
>>                                      PVOID UserContext)
>>     
> Use spaces, not tabs. How is PCSTR defined? What's about VC2005 & 7.x
> builds?
>
>   
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: win32-2.patch
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20080222/b4517338/attachment.ksh>