[LLVMbugs] Patch for Win32/MSVC compilation

Anton Korobeynikov asl at math.spbu.ru
Thu Feb 21 14:31:50 PST 2008

Hello, Argiris

> +#ifdef _MSC_VER
> +// Get std::equal_to
> +#include <functional>
> +#endif
Please, no compiler-specific defines outside libSystem / libSupport.
Most probably, we should pull <functional> unconditionally here, since
std::equal_to should be defined there according to standard.

> +  static BOOL CALLBACK ELM_Callback(
> +#ifdef __MINGW32__
> +									PSTR  ModuleName,
> +#else
> +									PCSTR  ModuleName,
> +#endif
>                                      ModuleBaseType ModuleBase,
>                                      ULONG ModuleSize,
>                                      PVOID UserContext)
Use spaces, not tabs. How is PCSTR defined? What's about VC2005 & 7.x

With best regards, Anton Korobeynikov.

Faculty of Mathematics & Mechanics, Saint Petersburg State University.

More information about the llvm-bugs mailing list