[llvm-branch-commits] [llvm] [mlir] [Support][llvm-mc] Add column checking to -verify directives (PR #227570)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Sep 29 22:56:22 PDT 2026


github-actions[bot] wrote:

<!--LLVM IDS CHECK COMMENT-->


:warning: LLVM ABI annotation checker, ids-check found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
Build idt from compnerd/ids, then for each changed header:
    idt -p build/ --main-file <matching-source.cpp> \
        --apply-fixits --inplace <header>
``````````

</details>

<details>
<summary>
View the diff from ids-check here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/Support/SourceMgrDiagnosticVerifier.h b/llvm/include/llvm/Support/SourceMgrDiagnosticVerifier.h
index 4ff2e96e1..2cd618daf 100644
--- a/llvm/include/llvm/Support/SourceMgrDiagnosticVerifier.h
+++ b/llvm/include/llvm/Support/SourceMgrDiagnosticVerifier.h
@@ -43,16 +43,16 @@ public:
         : Kind(Kind), LineNo(LineNo), FileLoc(FileLoc), Substring(Substring) {}
 
     /// Returns true if this diagnostic matches the given message.
-    bool match(StringRef Str) const;
+    LLVM_ABI bool match(StringRef Str) const;
 
     /// Computes the regex matcher for a '-re' diagnostic's substring.
     /// Returns false and prints a message through \p Mgr on error.
-    bool computeRegex(raw_ostream &OS, SourceMgr &Mgr);
+    LLVM_ABI bool computeRegex(raw_ostream &OS, SourceMgr &Mgr);
 
     /// Prints \p Msg at this diagnostic's location and returns false, for
     /// use as `return emitError(...);` in functions that report failure via
     /// a bool return.
-    bool emitError(raw_ostream &OS, SourceMgr &Mgr, const Twine &Msg) const;
+    LLVM_ABI bool emitError(raw_ostream &OS, SourceMgr &Mgr, const Twine &Msg) const;
 
     /// The severity of the diagnostic expected.
     SourceMgr::DiagKind Kind;

``````````

</details>


https://github.com/llvm/llvm-project/pull/227570


More information about the llvm-branch-commits mailing list