[llvm-branch-commits] [llvm] [Support] Fix offset parsing and buffer caching in SourceMgrDiagnosticVerifier (PR #227567)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Support/SourceMgrDiagnosticVerifier.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Support/SourceMgrDiagnosticVerifier.cpp b/llvm/lib/Support/SourceMgrDiagnosticVerifier.cpp
index b2102201b..8c39632c8 100644
--- a/llvm/lib/Support/SourceMgrDiagnosticVerifier.cpp
+++ b/llvm/lib/Support/SourceMgrDiagnosticVerifier.cpp
@@ -152,7 +152,8 @@ SourceMgrDiagnosticVerifier::computeExpectedDiags(raw_ostream &OS,
         // would silently discard the offset instead of reporting an error).
         if (OffsetMatch.drop_front().getAsInteger(10, Offset)) {
           OK = false;
-          Record.emitError(OS, Mgr, "invalid line offset '" + OffsetMatch + "'");
+          Record.emitError(OS, Mgr,
+                           "invalid line offset '" + OffsetMatch + "'");
           continue;
         }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/227567