[llvm-branch-commits] [libc] [libc][math] Fix fast path with small inputs for double precision sin/cos (#221012) (PR #225294)

Aiden Grossman via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sat Sep 26 20:34:49 PDT 2026


boomanaiden154 wrote:

> For this backport, let me remove the newly added worst-case test and the utilities. But at the moment, I think the benefits of having all of these worst cases will outweigh the size increase. And relative to the whole LLVM project checkout, its gain is not that significant. All of these files will be contained in a testing folder, so if any downstream projects want, they can exclude the folder without losing much.

Not blocking for this PR now that the plan is to look at it later, but maybe an lightweight/short RFC if we're going to do something like this to have a bit of discussion? I'm a lot more concerned about upstream CI than downstream checkouts (as in the former we do need to check out the entire repository in a lot of cases). If this turns out to be useful for more than just sin/cos, we also end up with quite a few files.

https://github.com/llvm/llvm-project/pull/225294


More information about the llvm-branch-commits mailing list