[llvm-branch-commits] [flang] [flang][OpenMP] Track reachable metadirective replacements (PR #219014)

[via llvm-branch-commits]

================
@@ -2389,9 +2392,8 @@ void ProcessTraitProperties(llvm::omp::VariantMatchInfo &vmi,
       vmi.addTrait(set, llvm::omp::TraitProperty::target_device_isa___ANY,
           name->v, scorePtr);
     } else {
-      // For non-ISA selectors (arch, kind, vendor, etc.), unknown properties
-      // mean the variant cannot match. Add an invalid trait to ensure it is
-      // not selected.
+      // Record unknown non-ISA properties as inactive traits. Whether an
+      // inactive trait excludes the variant depends on the matching mode.
----------------
MattPD wrote:

Fixed by https://github.com/llvm/llvm-project/pull/224431: Both selector orders report the diagnostic at 9dd52517.

https://github.com/llvm/llvm-project/pull/219014