[llvm-branch-commits] [clang] [analyzer][NFC] Index parameter lookups by argument position (PR #221977)

[Benedek Kaibas via llvm-branch-commits]

================
@@ -63,23 +80,27 @@ void setBitsAccordingToFunctionAttributes(const CallType &Call,
       // 'nonnull' attribute's parameters are 1-based and should be adjusted to
       // match actual AST parameter/argument indices.
       unsigned IdxAST = Idx.getASTIndex();
-      if (IdxAST >= AttrNonNull.size())
+      if (IdxAST < Offset)
+        continue;
+      const unsigned IdxArg = IdxAST - Offset;
----------------
benedekaibas wrote:

I could not find any helper function that would do the `IdxAST` -> `NativeIdx` conversion, so this was the simplest way I could come up with. I might miss something here, but I re-reead all the methods of `CallEvent` and none of them seems like a good fit.

https://github.com/llvm/llvm-project/pull/221977