[llvm-branch-commits] [compiler-rt] release/23.x: [win/asan] GetInstructionSize: Add some more instructions. (#219038) (PR #221969)

[Martin Storsjö via llvm-branch-commits]

mstorsjo wrote:

> What are the implications if we do not take this fix on the release branch? Would there be crashes? Bad codegen? Suboptimal ASAN usage?

The implications is that ASAN fails to work in some cases (depending on what compiler has generated code - in this case, in particular when ASAN is used inside Wine).

IMO, the fix is quite safe - it doesn't change how any other existing codepath behaves, but just makes ASAN able to handle more x86 instruction cases that it didn't before. And we're not that deep into the 23.1 release sequence yet, so I think it would be a reasonable change to backport at this point.

https://github.com/llvm/llvm-project/pull/221969