[llvm-branch-commits] [llvm] Users/adurango/lazy liboffload (PR #221270)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Fri Sep 4 09:17:37 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- offload/liboffload/src/OffloadImpl.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/offload/liboffload/src/OffloadImpl.cpp b/offload/liboffload/src/OffloadImpl.cpp
index 9c2a1beb2..09f232641 100644
--- a/offload/liboffload/src/OffloadImpl.cpp
+++ b/offload/liboffload/src/OffloadImpl.cpp
@@ -108,6 +108,7 @@ struct ol_device_impl_t {
return Info;
}
+
private:
GenericDeviceTy *Device = nullptr;
InfoTreeNode Info;
@@ -686,8 +687,7 @@ Error olCreateContext_impl(size_t DevicesCount, ol_device_handle_t *Devices,
if (Platform->Plugin) {
if (auto Err = Platform->init())
return Err;
- auto PluginCtxOrErr =
- Platform->Plugin->createPluginContext(PluginDevices);
+ auto PluginCtxOrErr = Platform->Plugin->createPluginContext(PluginDevices);
if (!PluginCtxOrErr)
return PluginCtxOrErr.takeError();
PluginCtx = std::move(*PluginCtxOrErr);
@@ -1093,8 +1093,9 @@ Error olGetEventElapsedTime_impl(ol_event_handle_t StartEvent,
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- auto ElapsedTimeOrErr = (*DeviceOrErr)->getEventElapsedTime(
- StartEvent->EventInfo, EndEvent->EventInfo);
+ auto ElapsedTimeOrErr =
+ (*DeviceOrErr)
+ ->getEventElapsedTime(StartEvent->EventInfo, EndEvent->EventInfo);
if (!ElapsedTimeOrErr)
return ElapsedTimeOrErr.takeError();
@@ -1107,8 +1108,9 @@ Error olDestroyEvent_impl(ol_event_handle_t Event) {
auto DeviceOrErr = Event->Device->getDevice();
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- if (auto Res = (*DeviceOrErr)->destroyEvent(Event->EventInfo,
- Event->ProfilingEnabled))
+ if (auto Res =
+ (*DeviceOrErr)
+ ->destroyEvent(Event->EventInfo, Event->ProfilingEnabled))
return Res;
}
@@ -1133,8 +1135,8 @@ Error olGetEventInfoImplDetail(ol_event_handle_t Event,
auto DeviceOrErr = Queue->Device->getDevice();
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- auto Res = (*DeviceOrErr)->isEventComplete(Event->EventInfo,
- Queue->AsyncInfo);
+ auto Res =
+ (*DeviceOrErr)->isEventComplete(Event->EventInfo, Queue->AsyncInfo);
if (auto Err = Res.takeError())
return Err;
return Info.write<bool>(*Res);
@@ -1171,11 +1173,11 @@ Error olCreateEvent_impl(ol_queue_handle_t Queue, ol_event_flags_t Flags,
if (auto Err = DeviceImpl->createEvent(&Event->EventInfo, EnableProfiling))
return Err;
- if (auto Err = DeviceImpl->recordEvent(
- Event->EventInfo, Queue->AsyncInfo, EnableProfiling)) {
+ if (auto Err = DeviceImpl->recordEvent(Event->EventInfo, Queue->AsyncInfo,
+ EnableProfiling)) {
if (Event->EventInfo) {
- if (auto DestroyErr = DeviceImpl->destroyEvent(
- Event->EventInfo, EnableProfiling))
+ if (auto DestroyErr =
+ DeviceImpl->destroyEvent(Event->EventInfo, EnableProfiling))
return joinErrors(std::move(Err), std::move(DestroyErr));
}
@@ -1210,28 +1212,24 @@ Error olMemcpy_impl(ol_queue_handle_t Queue, void *DstPtr,
auto QueueDeviceOrErr = Queue->Device->getDevice();
if (!QueueDeviceOrErr)
return QueueDeviceOrErr.takeError();
- return (*QueueDeviceOrErr)->dataMemcpy(DstPtr, SrcPtr, Size,
- Queue->AsyncInfo);
+ return (*QueueDeviceOrErr)
+ ->dataMemcpy(DstPtr, SrcPtr, Size, Queue->AsyncInfo);
}
// If no queue is given the memcpy will be synchronous
auto QueueImpl = Queue ? Queue->AsyncInfo : nullptr;
if (IsDstHost) {
- if (auto Res =
- SrcDeviceImpl->dataRetrieve(DstPtr, SrcPtr, Size, QueueImpl))
+ if (auto Res = SrcDeviceImpl->dataRetrieve(DstPtr, SrcPtr, Size, QueueImpl))
return Res;
} else if (IsSrcHost) {
- if (auto Res =
- DstDeviceImpl->dataSubmit(DstPtr, SrcPtr, Size, QueueImpl))
+ if (auto Res = DstDeviceImpl->dataSubmit(DstPtr, SrcPtr, Size, QueueImpl))
return Res;
- } else if (SrcDevice->Platform.Plugin ==
- DstDevice->Platform.Plugin &&
+ } else if (SrcDevice->Platform.Plugin == DstDevice->Platform.Plugin &&
SrcDevice->Platform.Plugin->isDataExchangable(
- SrcDeviceImpl->getDeviceId(),
- DstDeviceImpl->getDeviceId())) {
- if (auto Res = SrcDeviceImpl->dataExchange(SrcPtr, *DstDeviceImpl,
- DstPtr, Size, QueueImpl))
+ SrcDeviceImpl->getDeviceId(), DstDeviceImpl->getDeviceId())) {
+ if (auto Res = SrcDeviceImpl->dataExchange(SrcPtr, *DstDeviceImpl, DstPtr,
+ Size, QueueImpl))
return Res;
} else {
if (Queue)
@@ -1258,8 +1256,8 @@ Error olMemFill_impl(ol_queue_handle_t Queue, void *Ptr, size_t PatternSize,
auto DeviceOrErr = Queue->Device->getDevice();
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- return (*DeviceOrErr)->dataFill(Ptr, PatternPtr, PatternSize, FillSize,
- Queue->AsyncInfo);
+ return (*DeviceOrErr)
+ ->dataFill(Ptr, PatternPtr, PatternSize, FillSize, Queue->AsyncInfo);
}
Error olMemPrefetch_impl(ol_queue_handle_t Queue, size_t Count,
@@ -1272,8 +1270,8 @@ Error olMemPrefetch_impl(ol_queue_handle_t Queue, size_t Count,
auto DeviceOrErr = Queue->Device->getDevice();
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- return (*DeviceOrErr)->dataPrefetch(Count, Mems, Sizes, ToHost,
- Queue->AsyncInfo);
+ return (*DeviceOrErr)
+ ->dataPrefetch(Count, Mems, Sizes, ToHost, Queue->AsyncInfo);
}
Error olCreateProgram_impl(ol_context_handle_t Context,
@@ -1575,8 +1573,7 @@ Error olLaunchHostFunction_impl(ol_queue_handle_t Queue,
auto DeviceOrErr = Queue->Device->getDevice();
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- return (*DeviceOrErr)->enqueueHostCall(Callback, UserData,
- Queue->AsyncInfo);
+ return (*DeviceOrErr)->enqueueHostCall(Callback, UserData, Queue->AsyncInfo);
}
Error olMemRegister_impl(ol_device_handle_t Device, void *Ptr, size_t Size,
@@ -1585,8 +1582,10 @@ Error olMemRegister_impl(ol_device_handle_t Device, void *Ptr, size_t Size,
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- Expected<void *> LockedPtrOrErr = (*DeviceOrErr)->registerMemory(
- Ptr, Size, Flags & OL_MEMORY_REGISTER_FLAG_LOCK_MEMORY);
+ Expected<void *> LockedPtrOrErr =
+ (*DeviceOrErr)
+ ->registerMemory(Ptr, Size,
+ Flags & OL_MEMORY_REGISTER_FLAG_LOCK_MEMORY);
if (!LockedPtrOrErr)
return LockedPtrOrErr.takeError();
@@ -1600,8 +1599,8 @@ Error olMemUnregister_impl(ol_device_handle_t Device, void *Ptr,
auto DeviceOrErr = Device->getDevice();
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- return (*DeviceOrErr)->unregisterMemory(
- Ptr, Flags & OL_MEMORY_REGISTER_FLAG_UNLOCK_MEMORY);
+ return (*DeviceOrErr)
+ ->unregisterMemory(Ptr, Flags & OL_MEMORY_REGISTER_FLAG_UNLOCK_MEMORY);
}
Error olQueryQueue_impl(ol_queue_handle_t Queue, bool *IsQueueWorkCompleted) {
@@ -1609,8 +1608,9 @@ Error olQueryQueue_impl(ol_queue_handle_t Queue, bool *IsQueueWorkCompleted) {
auto DeviceOrErr = Queue->Device->getDevice();
if (!DeviceOrErr)
return DeviceOrErr.takeError();
- if (auto Err = (*DeviceOrErr)->queryAsync(Queue->AsyncInfo, false,
- IsQueueWorkCompleted))
+ if (auto Err =
+ (*DeviceOrErr)
+ ->queryAsync(Queue->AsyncInfo, false, IsQueueWorkCompleted))
return Err;
} else if (IsQueueWorkCompleted) {
// No underlying queue means there's no work to complete.
``````````
</details>
https://github.com/llvm/llvm-project/pull/221270
More information about the llvm-branch-commits
mailing list