[llvm-branch-commits] [libc] 52774ef - [libc] Clean up some unused includes (#220038)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Sep 1 14:54:11 PDT 2026


Author: Jackson Stogel
Date: 2026-08-31T12:07:17-07:00
New Revision: 52774ef910fe941d90b5594ce578e459fbb108a8

URL: https://github.com/llvm/llvm-project/commit/52774ef910fe941d90b5594ce578e459fbb108a8
DIFF: https://github.com/llvm/llvm-project/commit/52774ef910fe941d90b5594ce578e459fbb108a8.diff

LOG: [libc] Clean up some unused includes (#220038)

The `CMakeLists.txt` for these already reflect the correct dependencies
(e.g. `libc/startup/linux/x86_64/tls.cpp` depends on
`libc.config.app_h`, not `do_start`). I was adding some Bazel rules for
libc entrypoints and saw these unused deps.

Added: 
    

Modified: 
    libc/src/signal/linux/kill.cpp
    libc/src/stdio/remove.h
    libc/startup/linux/aarch64/tls.cpp
    libc/startup/linux/riscv/tls.cpp
    libc/startup/linux/x86_64/tls.cpp

Removed: 
    


################################################################################
diff  --git a/libc/src/signal/linux/kill.cpp b/libc/src/signal/linux/kill.cpp
index f6b6c3c052a5b..732ee1d353036 100644
--- a/libc/src/signal/linux/kill.cpp
+++ b/libc/src/signal/linux/kill.cpp
@@ -12,7 +12,6 @@
 #include "src/__support/common.h"
 #include "src/__support/libc_errno.h"
 #include "src/__support/macros/config.h"
-#include "src/signal/linux/signal_utils.h"
 
 #include <sys/syscall.h> // For syscall numbers.
 

diff  --git a/libc/src/stdio/remove.h b/libc/src/stdio/remove.h
index 267946ff27598..9a05f01dcb7ff 100644
--- a/libc/src/stdio/remove.h
+++ b/libc/src/stdio/remove.h
@@ -9,7 +9,6 @@
 #ifndef LLVM_LIBC_SRC_STDIO_REMOVE_H
 #define LLVM_LIBC_SRC_STDIO_REMOVE_H
 
-#include "hdr/types/FILE.h"
 #include "src/__support/macros/config.h"
 
 namespace LIBC_NAMESPACE_DECL {

diff  --git a/libc/startup/linux/aarch64/tls.cpp b/libc/startup/linux/aarch64/tls.cpp
index b925df16b8c60..bc35b85bdec46 100644
--- a/libc/startup/linux/aarch64/tls.cpp
+++ b/libc/startup/linux/aarch64/tls.cpp
@@ -6,6 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "config/app.h"
 #include "hdr/sys_mman_macros.h"
 #include "src/__support/OSUtil/linux/syscall_wrappers/mmap.h"
 #include "src/__support/OSUtil/linux/syscall_wrappers/munmap.h"
@@ -13,7 +14,6 @@
 #include "src/__support/macros/config.h"
 #include "src/__support/threads/thread.h"
 #include "src/string/memory_utils/inline_memcpy.h"
-#include "startup/linux/do_start.h"
 
 #include <arm_acle.h>
 #include <sys/syscall.h>

diff  --git a/libc/startup/linux/riscv/tls.cpp b/libc/startup/linux/riscv/tls.cpp
index 4081692cfa30e..87edca12c5b87 100644
--- a/libc/startup/linux/riscv/tls.cpp
+++ b/libc/startup/linux/riscv/tls.cpp
@@ -6,6 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "config/app.h"
 #include "hdr/sys_mman_macros.h"
 #include "src/__support/OSUtil/linux/syscall_wrappers/mmap.h"
 #include "src/__support/OSUtil/linux/syscall_wrappers/munmap.h"
@@ -13,7 +14,6 @@
 #include "src/__support/macros/config.h"
 #include "src/__support/threads/thread.h"
 #include "src/string/memory_utils/inline_memcpy.h"
-#include "startup/linux/do_start.h"
 #include <sys/syscall.h>
 
 namespace LIBC_NAMESPACE_DECL {

diff  --git a/libc/startup/linux/x86_64/tls.cpp b/libc/startup/linux/x86_64/tls.cpp
index 98c5fbeb9d84b..13f6491295fe8 100644
--- a/libc/startup/linux/x86_64/tls.cpp
+++ b/libc/startup/linux/x86_64/tls.cpp
@@ -6,13 +6,13 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "config/app.h"
 #include "hdr/sys_mman_macros.h"
 #include "src/__support/OSUtil/linux/syscall_wrappers/getrandom.h"
 #include "src/__support/OSUtil/linux/syscall_wrappers/mmap.h"
 #include "src/__support/OSUtil/linux/syscall_wrappers/munmap.h"
 #include "src/__support/macros/config.h"
 #include "src/string/memory_utils/inline_memcpy.h"
-#include "startup/linux/do_start.h"
 
 #include <asm/prctl.h>
 #include <sys/syscall.h>


        


More information about the llvm-branch-commits mailing list