[llvm-branch-commits] [Sparc] Port SparcDetectRoundChange to NewPM (PR #237657)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Sat Oct 31 16:55:37 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-sparc
Author: Aiden Grossman (boomanaiden154)
<details>
<summary>Changes</summary>
Standard NewPM pass porting.
The idea behind this pass seems to be fundamentally flawed and I'm sure
there's a better way to do this, but I'm trying not to get sucked into
fixing target specific issues as part of the NewPM migration.
---
Full diff: https://github.com/llvm/llvm-project/pull/237657.diff
7 Files Affected:
- (modified) llvm/lib/Target/Sparc/LeonPasses.cpp (+15-3)
- (modified) llvm/lib/Target/Sparc/LeonPasses.h (+8-2)
- (modified) llvm/lib/Target/Sparc/Sparc.h (+7)
- (modified) llvm/lib/Target/Sparc/SparcCodeGenPassBuilder.cpp (+1-1)
- (modified) llvm/lib/Target/Sparc/SparcPassRegistry.def (+1)
- (modified) llvm/lib/Target/Sparc/SparcTargetMachine.cpp (+1-1)
- (modified) llvm/test/CodeGen/SPARC/newpm-pipeline.ll (+1)
``````````diff
diff --git a/llvm/lib/Target/Sparc/LeonPasses.cpp b/llvm/lib/Target/Sparc/LeonPasses.cpp
index 9a70369b4375b..0b3f84cffee32 100644
--- a/llvm/lib/Target/Sparc/LeonPasses.cpp
+++ b/llvm/lib/Target/Sparc/LeonPasses.cpp
@@ -384,11 +384,12 @@ SparcInsertNOPLoadPass::run(MachineFunction &MF,
//
// Detects an erratum in UT699 LEON 3 processor
-char DetectRoundChange::ID = 0;
+char SparcDetectRoundChangeLegacy::ID = 0;
-DetectRoundChange::DetectRoundChange() : MachineFunctionPass(ID) {}
+SparcDetectRoundChangeLegacy::SparcDetectRoundChangeLegacy()
+ : MachineFunctionPass(ID) {}
-bool DetectRoundChange::runOnMachineFunction(MachineFunction &MF) {
+static bool detectRoundChangeOnMachineFunction(MachineFunction &MF) {
const SparcSubtarget *Subtarget = &MF.getSubtarget<SparcSubtarget>();
if (!Subtarget->detectRoundChange())
return false;
@@ -417,6 +418,17 @@ bool DetectRoundChange::runOnMachineFunction(MachineFunction &MF) {
return Modified;
}
+bool SparcDetectRoundChangeLegacy::runOnMachineFunction(MachineFunction &MF) {
+ return detectRoundChangeOnMachineFunction(MF);
+}
+
+PreservedAnalyses
+SparcDetectRoundChangePass::run(MachineFunction &MF,
+ MachineFunctionAnalysisManager &MFAM) {
+ detectRoundChangeOnMachineFunction(MF);
+ return PreservedAnalyses::all();
+}
+
//*****************************************************************************
//**** FixAllFDIVSQRT pass
//*****************************************************************************
diff --git a/llvm/lib/Target/Sparc/LeonPasses.h b/llvm/lib/Target/Sparc/LeonPasses.h
index df724a1f2d941..cace7766096f0 100644
--- a/llvm/lib/Target/Sparc/LeonPasses.h
+++ b/llvm/lib/Target/Sparc/LeonPasses.h
@@ -66,17 +66,23 @@ class LLVM_LIBRARY_VISIBILITY SparcInsertNOPLoadLegacy
}
};
-class LLVM_LIBRARY_VISIBILITY DetectRoundChange : public MachineFunctionPass {
+class LLVM_LIBRARY_VISIBILITY SparcDetectRoundChangeLegacy
+ : public MachineFunctionPass {
public:
static char ID;
- DetectRoundChange();
+ SparcDetectRoundChangeLegacy();
bool runOnMachineFunction(MachineFunction &MF) override;
StringRef getPassName() const override {
return "DetectRoundChange: Leon erratum detection: detect any rounding "
"mode change request: use only the round-to-nearest rounding mode";
}
+
+ void getAnalysisUsage(AnalysisUsage &AU) const override {
+ AU.setPreservesAll();
+ MachineFunctionPass::getAnalysisUsage(AU);
+ }
};
class LLVM_LIBRARY_VISIBILITY FixAllFDIVSQRT : public MachineFunctionPass {
diff --git a/llvm/lib/Target/Sparc/Sparc.h b/llvm/lib/Target/Sparc/Sparc.h
index 798f8df164a11..c926012eb16d5 100644
--- a/llvm/lib/Target/Sparc/Sparc.h
+++ b/llvm/lib/Target/Sparc/Sparc.h
@@ -58,6 +58,13 @@ class SparcInsertNOPLoadPass
MachineFunctionAnalysisManager &MFAM);
};
+class SparcDetectRoundChangePass
+ : public RequiredPassInfoMixin<SparcDetectRoundChangePass> {
+public:
+ PreservedAnalyses run(MachineFunction &MF,
+ MachineFunctionAnalysisManager &MFAM);
+};
+
void initializeSparcAsmPrinterPass(PassRegistry &);
void initializeSparcDAGToDAGISelLegacyPass(PassRegistry &);
void initializeErrataWorkaroundPass(PassRegistry &);
diff --git a/llvm/lib/Target/Sparc/SparcCodeGenPassBuilder.cpp b/llvm/lib/Target/Sparc/SparcCodeGenPassBuilder.cpp
index 6f7666c60be18..dd6fc3738dac6 100644
--- a/llvm/lib/Target/Sparc/SparcCodeGenPassBuilder.cpp
+++ b/llvm/lib/Target/Sparc/SparcCodeGenPassBuilder.cpp
@@ -57,7 +57,7 @@ void SparcCodeGenPassBuilder::addPreEmitPass(PassManagerWrapper &PMW) {
addMachineFunctionPass(SparcDelaySlotFillerPass(), PMW);
addMachineFunctionPass(SparcInsertNOPLoadPass(), PMW);
- // TODO(boomanaiden154): Add SparcDetectRoundChangePass
+ addMachineFunctionPass(SparcDetectRoundChangePass(), PMW);
// TODO(boomanaiden154): Add SparcFixAllFDIVSQRTPass
// TODO(boomanaiden154): Add SparcErrataWorkaroundPass
}
diff --git a/llvm/lib/Target/Sparc/SparcPassRegistry.def b/llvm/lib/Target/Sparc/SparcPassRegistry.def
index 51bbc6544661b..c8f45088c6481 100644
--- a/llvm/lib/Target/Sparc/SparcPassRegistry.def
+++ b/llvm/lib/Target/Sparc/SparcPassRegistry.def
@@ -17,6 +17,7 @@
#define MACHINE_FUNCTION_PASS(NAME, CREATE_PASS)
#endif
MACHINE_FUNCTION_PASS("sparc-delay-slot-filler", SparcDelaySlotFillerPass())
+MACHINE_FUNCTION_PASS("sparc-detect-round-change", SparcDetectRoundChangePass())
MACHINE_FUNCTION_PASS("sparc-insert-nop-load", SparcInsertNOPLoadPass())
MACHINE_FUNCTION_PASS("sparc-isel", SparcDAGToDAGISelPass(*this, getOptLevel()))
#undef MACHINE_FUNCTION_PASS
diff --git a/llvm/lib/Target/Sparc/SparcTargetMachine.cpp b/llvm/lib/Target/Sparc/SparcTargetMachine.cpp
index 3839d1d212ef6..0c4b4de8aff3c 100644
--- a/llvm/lib/Target/Sparc/SparcTargetMachine.cpp
+++ b/llvm/lib/Target/Sparc/SparcTargetMachine.cpp
@@ -167,7 +167,7 @@ void SparcPassConfig::addPreEmitPass(){
addPass(createSparcDelaySlotFillerLegacyPass());
addPass(new SparcInsertNOPLoadLegacy());
- addPass(new DetectRoundChange());
+ addPass(new SparcDetectRoundChangeLegacy());
addPass(new FixAllFDIVSQRT());
addPass(new ErrataWorkaround());
}
diff --git a/llvm/test/CodeGen/SPARC/newpm-pipeline.ll b/llvm/test/CodeGen/SPARC/newpm-pipeline.ll
index e20116a88fedb..470f8b4a55307 100644
--- a/llvm/test/CodeGen/SPARC/newpm-pipeline.ll
+++ b/llvm/test/CodeGen/SPARC/newpm-pipeline.ll
@@ -83,6 +83,7 @@
; SPARC-BR-RELAX-NEXT: branch-relaxation
; SPARC-NEXT: sparc-delay-slot-filler
; SPARC-NEXT: sparc-insert-nop-load
+; SPARC-NEXT: sparc-detect-round-change
; SPARC-NEXT: funclet-layout
; SPARC-NEXT: remove-loads-into-fake-uses
; SPARC-NEXT: StackMapLivenessPass
``````````
</details>
https://github.com/llvm/llvm-project/pull/237657
More information about the llvm-branch-commits
mailing list