[llvm-branch-commits] [Sparc] Remove LEONMachineFunctionPass base class (PR #237652)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sat Oct 31 16:35:20 PDT 2026


llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-sparc

Author: Aiden Grossman (boomanaiden154)

<details>
<summary>Changes</summary>

None of the members were even used, so just delete it. This makes
porting to the NewPM simpler.


---
Full diff: https://github.com/llvm/llvm-project/pull/237652.diff


2 Files Affected:

- (modified) llvm/lib/Target/Sparc/LeonPasses.cpp (+6-9) 
- (modified) llvm/lib/Target/Sparc/LeonPasses.h (+3-24) 


``````````diff
diff --git a/llvm/lib/Target/Sparc/LeonPasses.cpp b/llvm/lib/Target/Sparc/LeonPasses.cpp
index e1b7d22bfd483..5e7086cc0832e 100644
--- a/llvm/lib/Target/Sparc/LeonPasses.cpp
+++ b/llvm/lib/Target/Sparc/LeonPasses.cpp
@@ -319,9 +319,6 @@ bool ErrataWorkaround::runOnMachineFunction(MachineFunction &MF) {
   return Changed;
 }
 
-LEONMachineFunctionPass::LEONMachineFunctionPass(char &ID)
-    : MachineFunctionPass(ID) {}
-
 //*****************************************************************************
 //**** InsertNOPLoad pass
 //*****************************************************************************
@@ -334,10 +331,10 @@ LEONMachineFunctionPass::LEONMachineFunctionPass(char &ID)
 //
 char InsertNOPLoad::ID = 0;
 
-InsertNOPLoad::InsertNOPLoad() : LEONMachineFunctionPass(ID) {}
+InsertNOPLoad::InsertNOPLoad() : MachineFunctionPass(ID) {}
 
 bool InsertNOPLoad::runOnMachineFunction(MachineFunction &MF) {
-  Subtarget = &MF.getSubtarget<SparcSubtarget>();
+  const SparcSubtarget *Subtarget = &MF.getSubtarget<SparcSubtarget>();
   if (!Subtarget->insertNOPLoad())
     return false;
 
@@ -373,10 +370,10 @@ bool InsertNOPLoad::runOnMachineFunction(MachineFunction &MF) {
 
 char DetectRoundChange::ID = 0;
 
-DetectRoundChange::DetectRoundChange() : LEONMachineFunctionPass(ID) {}
+DetectRoundChange::DetectRoundChange() : MachineFunctionPass(ID) {}
 
 bool DetectRoundChange::runOnMachineFunction(MachineFunction &MF) {
-  Subtarget = &MF.getSubtarget<SparcSubtarget>();
+  const SparcSubtarget *Subtarget = &MF.getSubtarget<SparcSubtarget>();
   if (!Subtarget->detectRoundChange())
     return false;
 
@@ -423,10 +420,10 @@ bool DetectRoundChange::runOnMachineFunction(MachineFunction &MF) {
 //
 char FixAllFDIVSQRT::ID = 0;
 
-FixAllFDIVSQRT::FixAllFDIVSQRT() : LEONMachineFunctionPass(ID) {}
+FixAllFDIVSQRT::FixAllFDIVSQRT() : MachineFunctionPass(ID) {}
 
 bool FixAllFDIVSQRT::runOnMachineFunction(MachineFunction &MF) {
-  Subtarget = &MF.getSubtarget<SparcSubtarget>();
+  const SparcSubtarget *Subtarget = &MF.getSubtarget<SparcSubtarget>();
   if (!Subtarget->fixAllFDIVSQRT())
     return false;
 
diff --git a/llvm/lib/Target/Sparc/LeonPasses.h b/llvm/lib/Target/Sparc/LeonPasses.h
index 32271b30420ee..6b077d16bde13 100644
--- a/llvm/lib/Target/Sparc/LeonPasses.h
+++ b/llvm/lib/Target/Sparc/LeonPasses.h
@@ -17,26 +17,6 @@
 namespace llvm {
 class SparcSubtarget;
 
-class LLVM_LIBRARY_VISIBILITY LEONMachineFunctionPass
-    : public MachineFunctionPass {
-protected:
-  const SparcSubtarget *Subtarget = nullptr;
-  const int LAST_OPERAND = -1;
-
-  // this vector holds free registers that we allocate in groups for some of the
-  // LEON passes
-  std::vector<int> UsedRegisters;
-
-protected:
-  LEONMachineFunctionPass(char &ID);
-
-  void clearUsedRegisterList() { UsedRegisters.clear(); }
-
-  void markRegisterUsed(int registerIndex) {
-    UsedRegisters.push_back(registerIndex);
-  }
-};
-
 class LLVM_LIBRARY_VISIBILITY ErrataWorkaround : public MachineFunctionPass {
 protected:
   const SparcSubtarget *ST;
@@ -65,7 +45,7 @@ class LLVM_LIBRARY_VISIBILITY ErrataWorkaround : public MachineFunctionPass {
   StringRef getPassName() const override { return "Errata workaround pass"; };
 };
 
-class LLVM_LIBRARY_VISIBILITY InsertNOPLoad : public LEONMachineFunctionPass {
+class LLVM_LIBRARY_VISIBILITY InsertNOPLoad : public MachineFunctionPass {
 public:
   static char ID;
 
@@ -79,8 +59,7 @@ class LLVM_LIBRARY_VISIBILITY InsertNOPLoad : public LEONMachineFunctionPass {
   }
 };
 
-class LLVM_LIBRARY_VISIBILITY DetectRoundChange
-    : public LEONMachineFunctionPass {
+class LLVM_LIBRARY_VISIBILITY DetectRoundChange : public MachineFunctionPass {
 public:
   static char ID;
 
@@ -93,7 +72,7 @@ class LLVM_LIBRARY_VISIBILITY DetectRoundChange
   }
 };
 
-class LLVM_LIBRARY_VISIBILITY FixAllFDIVSQRT : public LEONMachineFunctionPass {
+class LLVM_LIBRARY_VISIBILITY FixAllFDIVSQRT : public MachineFunctionPass {
 public:
   static char ID;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/237652


More information about the llvm-branch-commits mailing list