[llvm-branch-commits] [llvm] [NFC][AMDGPU] Don't create call site AACallEdges for direct calls (PR #237633)

Matt Arsenault via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sat Oct 31 13:33:58 PDT 2026


================
@@ -1492,19 +1508,12 @@ struct AAAMDGPUNoLDSDMA : public StateWrapper<BooleanState, AbstractAttribute> {
                CB.hasFnAttr(Attribute::NoCallback);
       }
 
-      const auto *CBEdges = A.getAAFor<AACallEdges>(
-          *this, IRPosition::callsite_function(CB), DepClassTy::REQUIRED);
-      if (!CBEdges || CBEdges->hasUnknownCallee())
-        return false;
-
-      for (const Function *PossibleCallee : CBEdges->getOptimisticEdges()) {
-        const auto *CalleeInfo = A.getAAFor<AAAMDGPUNoLDSDMA>(
-            *this, IRPosition::function(*PossibleCallee), DepClassTy::REQUIRED);
-        if (!CalleeInfo || !CalleeInfo->getAssumed())
-          return false;
-      }
-
-      return true;
+      return checkForAllPossibleCallees(
+          A, *this, CB, [&](const Function &Callee) {
+            const AAAMDGPUNoLDSDMA *CalleeInfo = A.getAAFor<AAAMDGPUNoLDSDMA>(
----------------
arsenm wrote:

This patch is fine but as I commented on the PR that added this attribute, the attribute isn't necessary and should just be locally handled in the machine pass 

https://github.com/llvm/llvm-project/pull/237633


More information about the llvm-branch-commits mailing list