[llvm-branch-commits] [LSR] Precommit test for LCSSA preservation regression (PR #237531)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Sat Oct 31 02:22:29 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: Aiden Grossman (boomanaiden154)
<details>
<summary>Changes</summary>
We end up doing critical edge splitting in this test case which with
LCSSA preservation enabled prevents us from deleting some dead
instructions.
Assisted-By: LLM
---
Full diff: https://github.com/llvm/llvm-project/pull/237531.diff
1 Files Affected:
- (added) llvm/test/Transforms/LoopStrengthReduce/X86/incoming-dead-insts.ll (+55)
``````````diff
diff --git a/llvm/test/Transforms/LoopStrengthReduce/X86/incoming-dead-insts.ll b/llvm/test/Transforms/LoopStrengthReduce/X86/incoming-dead-insts.ll
new file mode 100644
index 0000000000000..46484a384d73e
--- /dev/null
+++ b/llvm/test/Transforms/LoopStrengthReduce/X86/incoming-dead-insts.ll
@@ -0,0 +1,55 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 6
+; RUN: opt < %s -passes="loop-reduce" -S | FileCheck %s
+
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+declare i1 @cond()
+
+define i64 @redundant_iv_crit_edge_exit(i64 %n) {
+; CHECK-LABEL: define i64 @redundant_iv_crit_edge_exit(
+; CHECK-SAME: i64 [[N:%.*]]) {
+; CHECK-NEXT: [[ENTRY:.*]]:
+; CHECK-NEXT: [[TMP0:%.*]] = sub i64 0, [[N]]
+; CHECK-NEXT: br label %[[LOOP_HEADER:.*]]
+; CHECK: [[LOOP_HEADER]]:
+; CHECK-NEXT: [[LSR_IV:%.*]] = phi i64 [ [[LSR_IV_NEXT:%.*]], %[[LOOP_LATCH:.*]] ], [ 3, %[[ENTRY]] ]
+; CHECK-NEXT: [[IV2:%.*]] = phi i64 [ 2, %[[ENTRY]] ], [ [[IV2_NEXT:%.*]], %[[LOOP_LATCH]] ]
+; CHECK-NEXT: [[IV2_NEXT]] = add nuw nsw i64 [[IV2]], 1
+; CHECK-NEXT: [[EARLY_COND:%.*]] = call i1 @cond()
+; CHECK-NEXT: br i1 [[EARLY_COND]], label %[[LOOP_LATCH]], label %[[LOOP_HEADER_EXIT_CRIT_EDGE:.*]]
+; CHECK: [[LOOP_LATCH]]:
+; CHECK-NEXT: [[LSR_IV_NEXT]] = add nuw i64 [[LSR_IV]], 1
+; CHECK-NEXT: [[TMP1:%.*]] = add i64 [[TMP0]], [[LSR_IV_NEXT]]
+; CHECK-NEXT: [[EXIT_COND:%.*]] = icmp eq i64 [[TMP1]], 3
+; CHECK-NEXT: br i1 [[EXIT_COND]], label %[[EXITSPLIT:.*]], label %[[LOOP_HEADER]]
+; CHECK: [[EXITSPLIT]]:
+; CHECK-NEXT: [[RES_PH:%.*]] = phi i64 [ 0, %[[LOOP_LATCH]] ]
+; CHECK-NEXT: br label %[[EXIT:.*]]
+; CHECK: [[LOOP_HEADER_EXIT_CRIT_EDGE]]:
+; CHECK-NEXT: [[LSR_IV_LCSSA:%.*]] = phi i64 [ [[LSR_IV]], %[[LOOP_HEADER]] ]
+; CHECK-NEXT: [[SPLIT:%.*]] = phi i64 [ [[IV2_NEXT]], %[[LOOP_HEADER]] ]
+; CHECK-NEXT: br label %[[EXIT]]
+; CHECK: [[EXIT]]:
+; CHECK-NEXT: [[RES:%.*]] = phi i64 [ [[LSR_IV_LCSSA]], %[[LOOP_HEADER_EXIT_CRIT_EDGE]] ], [ [[RES_PH]], %[[EXITSPLIT]] ]
+; CHECK-NEXT: ret i64 [[RES]]
+;
+entry:
+ br label %loop.header
+
+loop.header:
+ %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop.latch ]
+ %iv2 = phi i64 [ 2, %entry ], [ %iv2.next, %loop.latch ]
+ %iv2.next = add nuw nsw i64 %iv2, 1
+ %early.cond = call i1 @cond()
+ br i1 %early.cond, label %loop.latch, label %exit
+
+loop.latch:
+ %iv.next = add nuw nsw i64 %iv, 1
+ %exit.cond = icmp eq i64 %iv.next, %n
+ br i1 %exit.cond, label %exit, label %loop.header
+
+exit:
+ %res = phi i64 [ %iv2.next, %loop.header ], [ 0, %loop.latch ]
+ ret i64 %res
+}
``````````
</details>
https://github.com/llvm/llvm-project/pull/237531
More information about the llvm-branch-commits
mailing list