[llvm-branch-commits] [llvm] [VPlan] Use llvm.mask.beforefirst for computing early exit mask (PR #212717)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->


:warning: undef deprecator found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef([^a-zA-Z0-9_-]|$)|UndefValue::get)' 'HEAD~1' HEAD llvm/test/CodeGen/WebAssembly/mask-beforefirst.ll llvm/test/Transforms/InstCombine/mask-beforefirst.ll llvm/test/Transforms/InstSimplify/ConstProp/mask-beforefirst.ll llvm/lib/Analysis/ConstantFolding.cpp llvm/lib/Analysis/ValueTracking.cpp llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp llvm/test/CodeGen/X86/mask-beforefirst.ll llvm/test/Transforms/LoopVectorize/AArch64/early_exit_with_stores.ll llvm/test/Transforms/LoopVectorize/RISCV/early_exit_with_stores.ll llvm/test/Transforms/LoopVectorize/VPlan/early_exit_with_stores_vplan.ll llvm/test/Transforms/LoopVectorize/early_exit_combined_exits.ll llvm/test/Transforms/LoopVectorize/early_exit_combined_exits_epilogue.ll llvm/test/Transforms/LoopVectorize/early_exit_with_stores.ll llvm/test/Transforms/LoopVectorize/interleave_uncountable_exits.ll llvm/test/Transforms/LoopVectorize/scalarized_conditional_ops_uncountable_exits.ll llvm/test/Transforms/LoopVectorize/tail_fold_uncountable_exits.ll llvm/test/Transforms/PhaseOrdering/AArch64/countable-and-uncountable-exits-combined.ll
``````````

</details>


The following files introduce new uses of undef:
 - llvm/test/Transforms/InstSimplify/ConstProp/mask-beforefirst.ll

[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.

In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:
```llvm
define void @fn() {
  ...
  br i1 undef, ...
}
```

Please use the following instead:
```llvm
define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}
```

Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.



https://github.com/llvm/llvm-project/pull/212717