[llvm-branch-commits] [llvm] Attributor: Add only new attributes when manifesting (PR #234241)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 67128 tests passed
* 1080 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] unittests/IR/CMakeFiles/IRTests.dir/AttributesTest.cpp.obj</summary>

```
FAILED: [code=1] unittests/IR/CMakeFiles/IRTests.dir/AttributesTest.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\unittests\IR -IC:\_work\llvm-project\llvm-project\llvm\unittests\IR -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googlemock\include -imsvc"C:\BuildTools\DIA SDK\include" /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /Brepro -Wno-gnu-zero-variadic-macro-arguments /EHs-c- /GR- -Wno-suggest-override /showIncludes /Founittests\IR\CMakeFiles\IRTests.dir\AttributesTest.cpp.obj /Fdunittests\IR\CMakeFiles\IRTests.dir\ -c -- C:\_work\llvm-project\llvm-project\llvm\unittests\IR\AttributesTest.cpp
C:\_work\llvm-project\llvm-project\llvm\unittests\IR\AttributesTest.cpp(886,31): error: no matching member function for call to 'addAttributes'
886 |   EXPECT_DEATH(AttributeSet().addAttributes(C, {B1, A1}),
|                ~~~~~~~~~~~~~~~^~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/gtest-death-test.h(190,15): note: expanded from macro 'EXPECT_DEATH'
190 |   EXPECT_EXIT(statement, ::testing::internal::ExitedUnsuccessfully, matcher)
|               ^~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/gtest-death-test.h(179,21): note: expanded from macro 'EXPECT_EXIT'
179 |   GTEST_DEATH_TEST_(statement, predicate, matcher, GTEST_NONFATAL_FAILURE_)
|                     ^~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/internal/gtest-death-test-internal.h(243,47): note: expanded from macro 'GTEST_DEATH_TEST_'
243 |           GTEST_EXECUTE_DEATH_TEST_STATEMENT_(statement, gtest_dt);            \
|                                               ^~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/internal/gtest-death-test-internal.h(216,50): note: expanded from macro 'GTEST_EXECUTE_DEATH_TEST_STATEMENT_'
216 |   GTEST_SUPPRESS_UNREACHABLE_CODE_WARNING_BELOW_(statement)
|                                                  ^~~~~~~~~
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/internal/gtest-internal.h(1354,5): note: expanded from macro 'GTEST_SUPPRESS_UNREACHABLE_CODE_WARNING_BELOW_'
1354 |     statement;                                                    \
|     ^~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/Attributes.h(444,39): note: candidate function not viable: cannot convert initializer list argument to 'AttributeSet'
444 |   [[nodiscard]] LLVM_ABI AttributeSet addAttributes(LLVMContext &C,
|                                       ^
445 |                                                     AttributeSet AS) const;
|                                                     ~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/IR/Attributes.h(449,25): note: candidate function not viable: cannot convert initializer list argument to 'const AttrBuilder'
449 |   LLVM_ABI AttributeSet addAttributes(LLVMContext &C,
|                         ^
450 |                                       const AttrBuilder &B) const;
|                                       ~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/234241