[llvm-branch-commits] [clang] [NFC][clang][CodeGen] Remove redundant AlwaysInline on .inline builtin clones (PR #234095)

[via llvm-branch-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Vitaly Buka (vitalybuka)

<details>
<summary>Changes</summary>

`isInlineBuiltinDeclaration()` requires `AlwaysInlineAttr`, which is already
applied to `Clone` via `Fn->getAttributes()` and
`SetLLVMFunctionAttributesForDefinition`.

Assisted-by: Gemini

---
Full diff: https://github.com/llvm/llvm-project/pull/234095.diff


2 Files Affected:

- (modified) clang/lib/CodeGen/CGExpr.cpp (+1-3) 
- (modified) clang/lib/CodeGen/CodeGenFunction.cpp (-1) 


``````````diff
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index f6810d84cd235..c48d0349643ab 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -6719,12 +6719,10 @@ static CGCallee EmitDirectCallee(CodeGenFunction &CGF, GlobalDecl GD) {
       llvm::Function *Fn = llvm::cast<llvm::Function>(CalleePtr);
       llvm::Module *M = Fn->getParent();
       llvm::Function *Clone = M->getFunction(FDInlineName);
-      if (!Clone) {
+      if (!Clone)
         Clone = llvm::Function::Create(Fn->getFunctionType(),
                                        llvm::GlobalValue::InternalLinkage,
                                        Fn->getAddressSpace(), FDInlineName, M);
-        Clone->addFnAttr(llvm::Attribute::AlwaysInline);
-      }
       return CGCallee::forDirect(Clone, GD);
     }
 
diff --git a/clang/lib/CodeGen/CodeGenFunction.cpp b/clang/lib/CodeGen/CodeGenFunction.cpp
index 51588a7ebc556..f9423ff503447 100644
--- a/clang/lib/CodeGen/CodeGenFunction.cpp
+++ b/clang/lib/CodeGen/CodeGenFunction.cpp
@@ -1508,7 +1508,6 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD, llvm::Function *Fn,
     Clone->setCallingConv(Fn->getCallingConv());
     Clone->setAttributes(Fn->getAttributes());
     CGM.SetLLVMFunctionAttributesForDefinition(FD, Clone);
-    Clone->addFnAttr(llvm::Attribute::AlwaysInline);
     Fn->setLinkage(llvm::GlobalValue::ExternalLinkage);
     Fn = Clone;
   } else {

``````````

</details>


https://github.com/llvm/llvm-project/pull/234095