[llvm-branch-commits] [llvm] [AMDGPU] Retire dying uses before adding defs in GCNDownwardRPTracker (PR #228294)

[Dhruva Chakrabarti via llvm-branch-commits]

================
@@ -10,10 +10,12 @@
 
 # GCN: Unclustered High Register Pressure Reschedule stage successfully increased occupancy to 4
 
-# GCN-GCNTRACKER: Occupancy before scheduling: 3, after 4.
-# GCN-GCNTRACKER-NEXT: Ending scheduling stage: Max Occupancy Initial Schedule
+# GCN-GCNTRACKER: Starting scheduling stage: Max Occupancy Initial Schedule
+# GCN-GCNTRACKER-NOT: Occupancy before scheduling: 3
----------------
dhruvachak wrote:

The GCN CHECKS are without the tracker and were introduced by the original test, they are unchanged after this patch. The GCN-GCNTRACKER CHECKS were later introduced and they probably deviated from the original intent even before this patch. This patch actually reduced the register usage of the GCN-GCNTRACKER runs. But I agree, the prior negative checks did not convey the right message. I now changed them to mostly positive checks to make the intent clear.

https://github.com/llvm/llvm-project/pull/228294