[llvm-branch-commits] [llvm] Targets: Use none_of instead of not in AssemblerPredicate conditions (PR #232033)

Matt Arsenault via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Oct 14 11:49:13 PDT 2026


================
@@ -159,46 +159,46 @@ def isGFX6GFX7GFX8GFX9 :
             "Subtarget->getGeneration() == AMDGPUSubtarget::SEA_ISLANDS ||"
             "Subtarget->getGeneration() == AMDGPUSubtarget::VOLCANIC_ISLANDS ||"
             "Subtarget->getGeneration() == AMDGPUSubtarget::GFX9">,
-  AssemblerPredicate<(all_of (not FeatureGFX10Insts))>;
+  AssemblerPredicate<(all_of (none_of FeatureGFX10Insts))>;
 
 def isGFX6GFX7GFX8GFX9NotGFX90A :
   Predicate<"!Subtarget->hasGFX90AInsts() &&"
             "(Subtarget->getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS ||"
             " Subtarget->getGeneration() == AMDGPUSubtarget::SEA_ISLANDS ||"
             " Subtarget->getGeneration() == AMDGPUSubtarget::VOLCANIC_ISLANDS ||"
             " Subtarget->getGeneration() == AMDGPUSubtarget::GFX9)">,
-  AssemblerPredicate<(all_of (not FeatureGFX10Insts), (not FeatureGFX90AInsts))>;
+  AssemblerPredicate<(all_of (none_of FeatureGFX10Insts), (none_of FeatureGFX90AInsts))>;
 
 def isGFX6GFX7GFX8GFX9GFX10 :
   Predicate<"Subtarget->getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS ||"
             "Subtarget->getGeneration() == AMDGPUSubtarget::SEA_ISLANDS ||"
             "Subtarget->getGeneration() == AMDGPUSubtarget::VOLCANIC_ISLANDS ||"
             "Subtarget->getGeneration() == AMDGPUSubtarget::GFX9 ||"
             "Subtarget->getGeneration() == AMDGPUSubtarget::GFX10">,
-  AssemblerPredicate<(all_of (not FeatureGFX11Insts))>;
+  AssemblerPredicate<(all_of (none_of FeatureGFX11Insts))>;
----------------
arsenm wrote:

Actually you still have to, without more parser changes 

https://github.com/llvm/llvm-project/pull/232033


More information about the llvm-branch-commits mailing list