[llvm-branch-commits] [llvm] Targets: Use none_of instead of not in AssemblerPredicate conditions (PR #232033)

Matt Arsenault via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Oct 14 11:46:17 PDT 2026


================
@@ -323,20 +324,20 @@ def isGFX11Plus :
 def isGFX11GFX12 :
   Predicate<"Subtarget->getGeneration() == AMDGPUSubtarget::GFX11 ||"
             "Subtarget->getGeneration() == AMDGPUSubtarget::GFX12">,
-  AssemblerPredicate<(all_of FeatureGFX11Insts, (not FeatureGFX13Insts))>;
+  AssemblerPredicate<(all_of FeatureGFX11Insts, (none_of FeatureGFX13Insts))>;
 
 def isGFX11PlusNot12_50 :
   Predicate<"Subtarget->getGeneration() >= AMDGPUSubtarget::GFX11 &&"
             "(Subtarget->getGeneration() >= AMDGPUSubtarget::GFX13 || !Subtarget->hasGFX1250Insts())">,
-  AssemblerPredicate<(all_of FeatureGFX11Insts, (any_of FeatureGFX13Insts, (not FeatureGFX1250Insts)))>;
+  AssemblerPredicate<(all_of FeatureGFX11Insts, (any_of FeatureGFX13Insts, (none_of FeatureGFX1250Insts)))>;
 
 def isGFX12Only :
   Predicate<"Subtarget->getGeneration() == AMDGPUSubtarget::GFX12">,
-  AssemblerPredicate<(all_of FeatureGFX12Insts, (not FeatureGFX13Insts))>;
+  AssemblerPredicate<(all_of FeatureGFX12Insts, (none_of FeatureGFX13Insts))>;
----------------
arsenm wrote:

The point of this is to stop using not, this is not a syntactic preference 

https://github.com/llvm/llvm-project/pull/232033


More information about the llvm-branch-commits mailing list