[llvm-branch-commits] [llvm] Integrate: workflows/release-binaries: Improve Windows installer (#220414) (PR #228503)

[Saleem Abdulrasool via llvm-branch-commits]

compnerd wrote:

> Right now without a stable product code, every new point release gets a new code, thus it'll show as installed side-by-side with prior (point) releases, even if in reality it's installed once (overwritten) locally.

Right, that is a bug and we should fix that.

> > The code itself seems fine to cherry pick. I'm more concerned about the changes note (and I suspect that's where @tru is coming from). This change has minor changes to the installer configuration, adding the product code through the build system, which is a good robustness fix. But why does that mention the migration to WiX? The rest is just harnessing for validity and shouldn't impact the results.
> 
> Because the migration to WiX was done in version 23.1.0 and I wrote this patch probably a day before the 23.1.0 branch cutoff and I was hoping to integrate it before it released. I can adjust the comment.

Ah, I see. That helps understand the change, but I would prefer that we bring over the release note change as a separate cherry-pick from this - the fix to pin the product code. And, yes, I realize that this is merely a logistic aspect and the final result would be the same, but the point is more that what is being cherry-picked is a targeted fix - simply fixing the product code handling. The split would make it clear that we are doing a bug fix + documentation change rather than a massive change (which happens to have a small bit of code).

https://github.com/llvm/llvm-project/pull/228503