[llvm-branch-commits] [llvm] Reapply "[LoopInterchange] Add tests for loop control values in the outer preheader (NFC)" (#235520) (PR #235893)

Ryotaro Kasuga via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sun Nov 22 07:22:08 PST 2026


https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/235893

>From 54ae5a06fc10a5961dd81e0f4171b866288d3b7f Mon Sep 17 00:00:00 2001
From: Ryotaro Kasuga <ryotaro.kasuga at gmail.com>
Date: Mon, 26 Oct 2026 22:37:25 +0900
Subject: [PATCH] Reapply "[LoopInterchange] Add tests for loop control values
 in the outer preheader (NFC)" (#235520)

This reverts commit 063d4816ce9051924a61f5d1e31a05992ca221b8.

Add test cases where it matters whether the loop control values (the
initial and final values of the IVs) are available in the outer loop
preheader. These are corner cases where the work in #235496 changes
what loop-interchange can handle.

The original commit was reverted because one of the tests failed with
EXPENSIVE_CHECKS due to stale SCEV dispositions (#221571). This has
been fixed by #222175 (not yet, but it will be). This reapply also adds
-verify-scev to the RUN line so that the issue is caught without
EXPENSIVE_CHECKS.

Part of #235496

Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
---
 ...op-control-available-in-outer-preheader.ll | 126 ++++++++++++++++++
 1 file changed, 126 insertions(+)
 create mode 100644 llvm/test/Transforms/LoopInterchange/loop-control-available-in-outer-preheader.ll

diff --git a/llvm/test/Transforms/LoopInterchange/loop-control-available-in-outer-preheader.ll b/llvm/test/Transforms/LoopInterchange/loop-control-available-in-outer-preheader.ll
new file mode 100644
index 00000000000000..e5c83f21d299e4
--- /dev/null
+++ b/llvm/test/Transforms/LoopInterchange/loop-control-available-in-outer-preheader.ll
@@ -0,0 +1,126 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 6
+; RUN: opt < %s -passes=loop-interchange -loop-interchange-profitabilities=ignore -verify-scev -S | FileCheck %s
+
+; The start value of the inner induction variable is a function argument.
+;
+; for (i = 0; i < 256; i++)
+;   for (j = s; j < s + 256; j++)
+;     A[j - s][i] = 0;
+;
+define void @inner_iv_start_is_argument(ptr %A, i64 %s) {
+; CHECK-LABEL: define void @inner_iv_start_is_argument(
+; CHECK-SAME: ptr [[A:%.*]], i64 [[S:%.*]]) {
+; CHECK-NEXT:  [[ENTRY:.*]]:
+; CHECK-NEXT:    [[END:%.*]] = add nsw i64 [[S]], 256
+; CHECK-NEXT:    br label %[[OUTER_HEADER:.*]]
+; CHECK:       [[OUTER_HEADER]]:
+; CHECK-NEXT:    [[I:%.*]] = phi i64 [ 0, %[[ENTRY]] ], [ [[I_NEXT:%.*]], %[[OUTER_LATCH:.*]] ]
+; CHECK-NEXT:    br label %[[INNER_HEADER:.*]]
+; CHECK:       [[INNER_HEADER]]:
+; CHECK-NEXT:    [[J:%.*]] = phi i64 [ [[S]], %[[OUTER_HEADER]] ], [ [[J_NEXT:%.*]], %[[INNER_HEADER]] ]
+; CHECK-NEXT:    [[IDX:%.*]] = sub nsw i64 [[J]], [[S]]
+; CHECK-NEXT:    [[GEP:%.*]] = getelementptr inbounds [256 x i32], ptr [[A]], i64 [[IDX]], i64 [[I]]
+; CHECK-NEXT:    store i32 0, ptr [[GEP]], align 4
+; CHECK-NEXT:    [[J_NEXT]] = add nsw i64 [[J]], 1
+; CHECK-NEXT:    [[EC_J:%.*]] = icmp eq i64 [[J_NEXT]], [[END]]
+; CHECK-NEXT:    br i1 [[EC_J]], label %[[OUTER_LATCH]], label %[[INNER_HEADER]]
+; CHECK:       [[OUTER_LATCH]]:
+; CHECK-NEXT:    [[I_NEXT]] = add nuw nsw i64 [[I]], 1
+; CHECK-NEXT:    [[EC_I:%.*]] = icmp eq i64 [[I_NEXT]], 256
+; CHECK-NEXT:    br i1 [[EC_I]], label %[[EXIT:.*]], label %[[OUTER_HEADER]]
+; CHECK:       [[EXIT]]:
+; CHECK-NEXT:    ret void
+;
+entry:
+  %end = add nsw i64 %s, 256
+  br label %outer.header
+
+outer.header:
+  %i = phi i64 [ 0, %entry ], [ %i.next, %outer.latch ]
+  br label %inner.header
+
+inner.header:
+  %j = phi i64 [ %s, %outer.header ], [ %j.next, %inner.header ]
+  %idx = sub nsw i64 %j, %s
+  %gep = getelementptr inbounds [256 x i32], ptr %A, i64 %idx, i64 %i
+  store i32 0, ptr %gep, align 4
+  %j.next = add nsw i64 %j, 1
+  %ec.j = icmp eq i64 %j.next, %end
+  br i1 %ec.j, label %outer.latch, label %inner.header
+
+outer.latch:
+  %i.next = add nuw nsw i64 %i, 1
+  %ec.i = icmp eq i64 %i.next, 256
+  br i1 %ec.i, label %exit, label %outer.header
+
+exit:
+  ret void
+}
+
+; The trip count of the inner loop is computed in the outer loop header by an
+; instruction that SCEV cannot analyze.
+;
+; for (i = 0; i < 256; i++) {
+;   bound = 500 % -200;
+;   for (j = 0; j != bound; j++)
+;     A[j][i] = 0;
+; }
+;
+define void @inner_trip_count_in_outer_header(ptr %A) {
+; CHECK-LABEL: define void @inner_trip_count_in_outer_header(
+; CHECK-SAME: ptr [[A:%.*]]) {
+; CHECK-NEXT:  [[ENTRY:.*:]]
+; CHECK-NEXT:    br label %[[INNER_HEADER_PREHEADER:.*]]
+; CHECK:       [[OUTER_HEADER_PREHEADER:.*]]:
+; CHECK-NEXT:    br label %[[OUTER_HEADER:.*]]
+; CHECK:       [[OUTER_HEADER]]:
+; CHECK-NEXT:    [[I:%.*]] = phi i64 [ [[I_NEXT:%.*]], %[[OUTER_LATCH:.*]] ], [ 0, %[[OUTER_HEADER_PREHEADER]] ]
+; CHECK-NEXT:    [[BOUND:%.*]] = srem i64 500, -200
+; CHECK-NEXT:    br label %[[INNER_HEADER_SPLIT1:.*]]
+; CHECK:       [[INNER_HEADER_PREHEADER]]:
+; CHECK-NEXT:    br label %[[INNER_HEADER:.*]]
+; CHECK:       [[INNER_HEADER]]:
+; CHECK-NEXT:    [[J:%.*]] = phi i64 [ [[TMP0:%.*]], %[[INNER_HEADER_SPLIT:.*]] ], [ 0, %[[INNER_HEADER_PREHEADER]] ]
+; CHECK-NEXT:    br label %[[OUTER_HEADER_PREHEADER]]
+; CHECK:       [[INNER_HEADER_SPLIT1]]:
+; CHECK-NEXT:    [[GEP:%.*]] = getelementptr inbounds [256 x i32], ptr [[A]], i64 [[J]], i64 [[I]]
+; CHECK-NEXT:    store i32 0, ptr [[GEP]], align 4
+; CHECK-NEXT:    [[J_NEXT:%.*]] = add nuw nsw i64 [[J]], 1
+; CHECK-NEXT:    [[EC_J:%.*]] = icmp eq i64 [[J_NEXT]], [[BOUND]]
+; CHECK-NEXT:    br label %[[OUTER_LATCH]]
+; CHECK:       [[INNER_HEADER_SPLIT]]:
+; CHECK-NEXT:    [[BOUND_LCSSA:%.*]] = phi i64 [ [[BOUND]], %[[OUTER_LATCH]] ]
+; CHECK-NEXT:    [[TMP0]] = add nuw nsw i64 [[J]], 1
+; CHECK-NEXT:    [[TMP1:%.*]] = icmp eq i64 [[TMP0]], [[BOUND_LCSSA]]
+; CHECK-NEXT:    br i1 [[TMP1]], label %[[EXIT:.*]], label %[[INNER_HEADER]]
+; CHECK:       [[OUTER_LATCH]]:
+; CHECK-NEXT:    [[I_NEXT]] = add nuw nsw i64 [[I]], 1
+; CHECK-NEXT:    [[EC_I:%.*]] = icmp eq i64 [[I_NEXT]], 256
+; CHECK-NEXT:    br i1 [[EC_I]], label %[[INNER_HEADER_SPLIT]], label %[[OUTER_HEADER]]
+; CHECK:       [[EXIT]]:
+; CHECK-NEXT:    ret void
+;
+entry:
+  br label %outer.header
+
+outer.header:
+  %i = phi i64 [ 0, %entry ], [ %i.next, %outer.latch ]
+  %bound = srem i64 500, -200
+  br label %inner.header
+
+inner.header:
+  %j = phi i64 [ 0, %outer.header ], [ %j.next, %inner.header ]
+  %gep = getelementptr inbounds [256 x i32], ptr %A, i64 %j, i64 %i
+  store i32 0, ptr %gep, align 4
+  %j.next = add nuw nsw i64 %j, 1
+  %ec.j = icmp eq i64 %j.next, %bound
+  br i1 %ec.j, label %outer.latch, label %inner.header
+
+outer.latch:
+  %i.next = add nuw nsw i64 %i, 1
+  %ec.i = icmp eq i64 %i.next, 256
+  br i1 %ec.i, label %exit, label %outer.header
+
+exit:
+  ret void
+}



More information about the llvm-branch-commits mailing list