[llvm-branch-commits] [libc] Add strcmp benchmark (PR #244924)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Sat Nov 21 12:15:02 PST 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Aiden Grossman (boomanaiden154)
<details>
<summary>Changes</summary>
To guide some optimization work around implementing an optimized strcmp
implementation.
---
Full diff: https://github.com/llvm/llvm-project/pull/244924.diff
7 Files Affected:
- (modified) libc/benchmarks/CMakeLists.txt (+4)
- (modified) libc/benchmarks/LibcDefaultImplementations.cpp (+7)
- (modified) libc/benchmarks/LibcFunctionPrototypes.h (+6)
- (modified) libc/benchmarks/LibcMemoryBenchmark.cpp (+6-3)
- (modified) libc/benchmarks/LibcMemoryBenchmark.h (+5)
- (modified) libc/benchmarks/LibcMemoryBenchmarkMain.cpp (+4)
- (modified) libc/benchmarks/LibcMemoryGoogleBenchmarkMain.cpp (+5)
``````````diff
diff --git a/libc/benchmarks/CMakeLists.txt b/libc/benchmarks/CMakeLists.txt
index a352f20a1eec4..cfe3a07d2b157 100644
--- a/libc/benchmarks/CMakeLists.txt
+++ b/libc/benchmarks/CMakeLists.txt
@@ -243,6 +243,9 @@ if(LIBC_BENCHMARKS_HAS_LLVM_SUPPORT)
if(TARGET libc.src.string.strlen)
add_libc_benchmark(strlen libc.src.string.strlen)
endif()
+ if(TARGET libc.src.string.strcmp)
+ add_libc_benchmark(strcmp libc.src.string.strcmp)
+ endif()
endif()
#==============================================================================
@@ -268,6 +271,7 @@ target_link_libraries(libc.benchmarks.memory_functions.opt_host
libc.src.strings.bzero_opt_host.__internal__
libc.src.string.memchr.__internal__
libc.src.string.strlen.__internal__
+ libc.src.string.strcmp.__internal__
benchmark_main
)
llvm_update_compile_flags(libc.benchmarks.memory_functions.opt_host)
diff --git a/libc/benchmarks/LibcDefaultImplementations.cpp b/libc/benchmarks/LibcDefaultImplementations.cpp
index 2e80ec69a8d10..995f4cd42845b 100644
--- a/libc/benchmarks/LibcDefaultImplementations.cpp
+++ b/libc/benchmarks/LibcDefaultImplementations.cpp
@@ -13,6 +13,7 @@ extern int memcmp(const void *, const void *, size_t);
extern int bcmp(const void *, const void *, size_t);
extern void *memchr(const void *, int, size_t);
extern size_t strlen(const char *);
+extern int strcmp(const char *, const char *);
} // namespace LIBC_NAMESPACE_DECL
@@ -24,6 +25,7 @@ using llvm::libc_benchmarks::MemcmpOrBcmpConfiguration;
using llvm::libc_benchmarks::MemcpyConfiguration;
using llvm::libc_benchmarks::MemmoveConfiguration;
using llvm::libc_benchmarks::MemsetConfiguration;
+using llvm::libc_benchmarks::StrcmpConfiguration;
using llvm::libc_benchmarks::StrlenConfiguration;
llvm::ArrayRef<MemcpyConfiguration> getMemcpyConfigurations() {
@@ -66,3 +68,8 @@ llvm::ArrayRef<StrlenConfiguration> getStrlenConfigurations() {
{LIBC_NAMESPACE::strlen, "LIBC_NAMESPACE::strlen"}};
return llvm::ArrayRef(kStrlenConfigurations);
}
+llvm::ArrayRef<StrcmpConfiguration> getStrcmpConfigurations() {
+ static constexpr StrcmpConfiguration kStrcmpConfigurations[] = {
+ {LIBC_NAMESPACE::strcmp, "LIBC_NAMESPACE::strcmp"}};
+ return llvm::ArrayRef(kStrcmpConfigurations);
+}
diff --git a/libc/benchmarks/LibcFunctionPrototypes.h b/libc/benchmarks/LibcFunctionPrototypes.h
index 0ac8ca97f1bea..836b61ae29fb4 100644
--- a/libc/benchmarks/LibcFunctionPrototypes.h
+++ b/libc/benchmarks/LibcFunctionPrototypes.h
@@ -50,6 +50,12 @@ struct StrlenConfiguration {
llvm::StringRef name;
};
+using StrcmpFunction = int (*)(const char *, const char *);
+struct StrcmpConfiguration {
+ StrcmpFunction function;
+ llvm::StringRef name;
+};
+
} // namespace libc_benchmarks
} // namespace llvm
diff --git a/libc/benchmarks/LibcMemoryBenchmark.cpp b/libc/benchmarks/LibcMemoryBenchmark.cpp
index bce2738d69f83..7330407778386 100644
--- a/libc/benchmarks/LibcMemoryBenchmark.cpp
+++ b/libc/benchmarks/LibcMemoryBenchmark.cpp
@@ -146,9 +146,12 @@ MoveSetup::MoveSetup()
ComparisonSetup::ComparisonSetup()
: ParameterBatch(2), lhs_buffer(ParameterBatch::buffer_size),
rhs_buffer(ParameterBatch::buffer_size) {
- // The memcmp buffers always compare equal.
- memset(lhs_buffer.begin(), 0xF, buffer_size);
- memset(rhs_buffer.begin(), 0xF, buffer_size);
+ // The memcmp/strcmp buffers always compare equal, with a null terminator at
+ // the end for strcmp.
+ memset(lhs_buffer.begin(), 0xF, buffer_size - 1);
+ memset(rhs_buffer.begin(), 0xF, buffer_size - 1);
+ lhs_buffer[buffer_size - 1] = '\0';
+ rhs_buffer[buffer_size - 1] = '\0';
}
SetSetup::SetSetup()
diff --git a/libc/benchmarks/LibcMemoryBenchmark.h b/libc/benchmarks/LibcMemoryBenchmark.h
index 7427543eb543d..86515cd9d5fbf 100644
--- a/libc/benchmarks/LibcMemoryBenchmark.h
+++ b/libc/benchmarks/LibcMemoryBenchmark.h
@@ -275,6 +275,11 @@ struct ComparisonSetup : public ParameterBatch {
parameter.size_bytes);
}
+ inline int call(ParameterType parameter, StrcmpFunction strcmp_func) {
+ return strcmp_func(lhs_buffer + buffer_size - 1 - parameter.size_bytes,
+ rhs_buffer + buffer_size - 1 - parameter.size_bytes);
+ }
+
private:
AlignedBuffer lhs_buffer;
AlignedBuffer rhs_buffer;
diff --git a/libc/benchmarks/LibcMemoryBenchmarkMain.cpp b/libc/benchmarks/LibcMemoryBenchmarkMain.cpp
index 76414d8256420..dbacf71aee8ca 100644
--- a/libc/benchmarks/LibcMemoryBenchmarkMain.cpp
+++ b/libc/benchmarks/LibcMemoryBenchmarkMain.cpp
@@ -32,6 +32,7 @@ extern int memcmp(const void *, const void *, size_t);
extern int bcmp(const void *, const void *, size_t);
extern void *memchr(const void *, int, size_t);
extern size_t strlen(const char *);
+extern int strcmp(const char *, const char *);
} // namespace LIBC_NAMESPACE_DECL
@@ -99,6 +100,9 @@ using BenchmarkSetup = SearchSetup;
#elif defined(LIBC_BENCHMARK_FUNCTION_STRLEN)
#define LIBC_BENCHMARK_FUNCTION LIBC_BENCHMARK_FUNCTION_STRLEN
using BenchmarkSetup = SearchSetup;
+#elif defined(LIBC_BENCHMARK_FUNCTION_STRCMP)
+#define LIBC_BENCHMARK_FUNCTION LIBC_BENCHMARK_FUNCTION_STRCMP
+using BenchmarkSetup = ComparisonSetup;
#else
#error "Missing LIBC_BENCHMARK_FUNCTION_XXX definition"
#endif
diff --git a/libc/benchmarks/LibcMemoryGoogleBenchmarkMain.cpp b/libc/benchmarks/LibcMemoryGoogleBenchmarkMain.cpp
index d3d1d3ca2b346..6562366e8683c 100644
--- a/libc/benchmarks/LibcMemoryGoogleBenchmarkMain.cpp
+++ b/libc/benchmarks/LibcMemoryGoogleBenchmarkMain.cpp
@@ -29,6 +29,7 @@ using llvm::libc_benchmarks::MoveSetup;
using llvm::libc_benchmarks::OffsetDistribution;
using llvm::libc_benchmarks::SearchSetup;
using llvm::libc_benchmarks::SetSetup;
+using llvm::libc_benchmarks::StrcmpConfiguration;
using llvm::libc_benchmarks::StrlenConfiguration;
// Alignment to use for when accessing the buffers.
@@ -134,3 +135,7 @@ BENCHMARK_MEMORY_FUNCTION(BM_Memchr, SearchSetup, MemchrConfiguration,
extern llvm::ArrayRef<StrlenConfiguration> getStrlenConfigurations();
BENCHMARK_MEMORY_FUNCTION(BM_Strlen, SearchSetup, StrlenConfiguration,
getStrlenConfigurations());
+
+extern llvm::ArrayRef<StrcmpConfiguration> getStrcmpConfigurations();
+BENCHMARK_MEMORY_FUNCTION(BM_Strcmp, ComparisonSetup, StrcmpConfiguration,
+ getStrcmpConfigurations());
``````````
</details>
https://github.com/llvm/llvm-project/pull/244924
More information about the llvm-branch-commits
mailing list