[llvm-branch-commits] [clang] [flang] [mlir] [mlir][LLVM] Include LLVM dialect partition headers instead of LLVMDialect.h (PR #242307)

Markus Böck via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Nov 17 02:21:33 PST 2026


zero9178 wrote:

> It's not obvious to me what LLVMDialectDecl.h contains, otherwise LGTM.

We unfortunately have a bit of an inconsistency upstream regarding this where some dialects use `<Name>Dialect.h` to include all ops of a dialect, some have `<Name>Ops.h` (which I prefer) but if one has the former and then only wants the dialect definition rather than all ops, some dialects (e.g. NVVM and LLVM) created a `<Name>DialectDecl.h` header where they moved the dialect class definition into.

Not the biggest fan of `<Name>DialectDecl.h` myself but a separate change that we should seek alignment on and make consistent.

https://github.com/llvm/llvm-project/pull/242307


More information about the llvm-branch-commits mailing list