[llvm-branch-commits] [llvm] [GVN] Fold equivalent `bitextract` and `bitinsert` (PR #237785)
Pedro Lobo via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Sat Nov 14 14:04:34 PST 2026
https://github.com/pedroclobo updated https://github.com/llvm/llvm-project/pull/237785
>From cda3639f7d70b0c67a041f0a112a1f577645a01f Mon Sep 17 00:00:00 2001
From: Pedro Lobo <pedro.lobo at tecnico.ulisboa.pt>
Date: Fri, 30 Oct 2026 22:13:16 +0000
Subject: [PATCH 1/2] [GVN] Pre-commit tests for equivalent `bitextract` and
`bitinsert`
---
.../Transforms/GVN/bitextract-bitinsert.ll | 133 ++++++++++++++++++
1 file changed, 133 insertions(+)
create mode 100644 llvm/test/Transforms/GVN/bitextract-bitinsert.ll
diff --git a/llvm/test/Transforms/GVN/bitextract-bitinsert.ll b/llvm/test/Transforms/GVN/bitextract-bitinsert.ll
new file mode 100644
index 00000000000000..c33518cb701e56
--- /dev/null
+++ b/llvm/test/Transforms/GVN/bitextract-bitinsert.ll
@@ -0,0 +1,133 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 6
+; RUN: opt < %s -passes=gvn -S | FileCheck %s
+
+declare void @use(...)
+
+define i8 @bitextract(b32 %b) {
+; CHECK-LABEL: define i8 @bitextract(
+; CHECK-SAME: b32 [[B:%.*]]) {
+; CHECK-NEXT: [[X:%.*]] = bitextract i8, b32 [[B]], i32 8
+; CHECK-NEXT: [[Y:%.*]] = bitextract i8, b32 [[B]], i32 8
+; CHECK-NEXT: [[R:%.*]] = add i8 [[X]], [[Y]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %x = bitextract i8, b32 %b, i32 8
+ %y = bitextract i8, b32 %b, i32 8
+ %r = add i8 %x, %y
+ ret i8 %r
+}
+
+define void @bitinsert(b32 %b, i8 %v) {
+; CHECK-LABEL: define void @bitinsert(
+; CHECK-SAME: b32 [[B:%.*]], i8 [[V:%.*]]) {
+; CHECK-NEXT: [[X:%.*]] = bitinsert b32 [[B]], i8 [[V]], i32 8
+; CHECK-NEXT: [[Y:%.*]] = bitinsert b32 [[B]], i8 [[V]], i32 8
+; CHECK-NEXT: call void (...) @use(b32 [[X]], b32 [[Y]])
+; CHECK-NEXT: ret void
+;
+ %x = bitinsert b32 %b, i8 %v, i32 8
+ %y = bitinsert b32 %b, i8 %v, i32 8
+ call void (...) @use(b32 %x, b32 %y)
+ ret void
+}
+
+; The offsets differ.
+define i8 @neg_bitextract_offset(b32 %b) {
+; CHECK-LABEL: define i8 @neg_bitextract_offset(
+; CHECK-SAME: b32 [[B:%.*]]) {
+; CHECK-NEXT: [[X:%.*]] = bitextract i8, b32 [[B]], i32 8
+; CHECK-NEXT: [[Y:%.*]] = bitextract i8, b32 [[B]], i32 16
+; CHECK-NEXT: [[R:%.*]] = add i8 [[X]], [[Y]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %x = bitextract i8, b32 %b, i32 8
+ %y = bitextract i8, b32 %b, i32 16
+ %r = add i8 %x, %y
+ ret i8 %r
+}
+
+; The result types differ.
+define void @neg_bitextract_type(b32 %b) {
+; CHECK-LABEL: define void @neg_bitextract_type(
+; CHECK-SAME: b32 [[B:%.*]]) {
+; CHECK-NEXT: [[X:%.*]] = bitextract i8, b32 [[B]], i32 8
+; CHECK-NEXT: [[Y:%.*]] = bitextract b8, b32 [[B]], i32 8
+; CHECK-NEXT: call void (...) @use(i8 [[X]], b8 [[Y]])
+; CHECK-NEXT: ret void
+;
+ %x = bitextract i8, b32 %b, i32 8
+ %y = bitextract b8, b32 %b, i32 8
+ call void (...) @use(i8 %x, b8 %y)
+ ret void
+}
+
+; %x doesn't dominate %y.
+define void @neg_bitextract_dom(i1 %c, b32 %b) {
+; CHECK-LABEL: define void @neg_bitextract_dom(
+; CHECK-SAME: i1 [[C:%.*]], b32 [[B:%.*]]) {
+; CHECK-NEXT: br i1 [[C]], label %[[THEN:.*]], label %[[ELSE:.*]]
+; CHECK: [[THEN]]:
+; CHECK-NEXT: [[X:%.*]] = bitextract i8, b32 [[B]], i32 8
+; CHECK-NEXT: call void (...) @use(i8 [[X]])
+; CHECK-NEXT: ret void
+; CHECK: [[ELSE]]:
+; CHECK-NEXT: [[Y:%.*]] = bitextract i8, b32 [[B]], i32 8
+; CHECK-NEXT: call void (...) @use(i8 [[Y]])
+; CHECK-NEXT: ret void
+;
+ br i1 %c, label %then, label %else
+
+then:
+ %x = bitextract i8, b32 %b, i32 8
+ call void (...) @use(i8 %x)
+ ret void
+
+else:
+ %y = bitextract i8, b32 %b, i32 8
+ call void (...) @use(i8 %y)
+ ret void
+}
+
+; The offsets differ.
+define void @neg_bitinsert_offset(b32 %b, i8 %v) {
+; CHECK-LABEL: define void @neg_bitinsert_offset(
+; CHECK-SAME: b32 [[B:%.*]], i8 [[V:%.*]]) {
+; CHECK-NEXT: [[X:%.*]] = bitinsert b32 [[B]], i8 [[V]], i32 8
+; CHECK-NEXT: [[Y:%.*]] = bitinsert b32 [[B]], i8 [[V]], i32 16
+; CHECK-NEXT: call void (...) @use(b32 [[X]], b32 [[Y]])
+; CHECK-NEXT: ret void
+;
+ %x = bitinsert b32 %b, i8 %v, i32 8
+ %y = bitinsert b32 %b, i8 %v, i32 16
+ call void (...) @use(b32 %x, b32 %y)
+ ret void
+}
+
+define void @bitextract_vec(<2 x b32> %b) {
+; CHECK-LABEL: define void @bitextract_vec(
+; CHECK-SAME: <2 x b32> [[B:%.*]]) {
+; CHECK-NEXT: [[X:%.*]] = bitextract <2 x i8>, <2 x b32> [[B]], <2 x i32> <i32 0, i32 8>
+; CHECK-NEXT: [[Y:%.*]] = bitextract <2 x i8>, <2 x b32> [[B]], <2 x i32> <i32 0, i32 8>
+; CHECK-NEXT: call void (...) @use(<2 x i8> [[X]], <2 x i8> [[Y]])
+; CHECK-NEXT: ret void
+;
+ %x = bitextract <2 x i8>, <2 x b32> %b, <2 x i32> <i32 0, i32 8>
+ %y = bitextract <2 x i8>, <2 x b32> %b, <2 x i32> <i32 0, i32 8>
+ call void (...) @use(<2 x i8> %x, <2 x i8> %y)
+ ret void
+}
+
+; The offsets differ in one element.
+define void @neg_bitextract_vec_offset(<2 x b32> %b) {
+; CHECK-LABEL: define void @neg_bitextract_vec_offset(
+; CHECK-SAME: <2 x b32> [[B:%.*]]) {
+; CHECK-NEXT: [[X:%.*]] = bitextract <2 x i8>, <2 x b32> [[B]], <2 x i32> <i32 0, i32 8>
+; CHECK-NEXT: [[Y:%.*]] = bitextract <2 x i8>, <2 x b32> [[B]], <2 x i32> <i32 0, i32 16>
+; CHECK-NEXT: call void (...) @use(<2 x i8> [[X]], <2 x i8> [[Y]])
+; CHECK-NEXT: ret void
+;
+ %x = bitextract <2 x i8>, <2 x b32> %b, <2 x i32> <i32 0, i32 8>
+ %y = bitextract <2 x i8>, <2 x b32> %b, <2 x i32> <i32 0, i32 16>
+ call void (...) @use(<2 x i8> %x, <2 x i8> %y)
+ ret void
+}
>From 86593804ef3b4c4c20c5f6f0ffa7e2a6f5a9533c Mon Sep 17 00:00:00 2001
From: Pedro Lobo <pedro.lobo at tecnico.ulisboa.pt>
Date: Fri, 30 Oct 2026 22:19:25 +0000
Subject: [PATCH 2/2] [GVN] Fold equivalent `bitextract` and `bitinsert`
---
llvm/lib/Transforms/Scalar/GVN.cpp | 2 ++
llvm/test/Transforms/GVN/bitextract-bitinsert.ll | 9 +++------
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp
index f4e927cb174e0d..d20db3d4d7f00c 100644
--- a/llvm/lib/Transforms/Scalar/GVN.cpp
+++ b/llvm/lib/Transforms/Scalar/GVN.cpp
@@ -970,6 +970,8 @@ uint32_t GVNValueTable::lookupOrAdd(Value *V) {
case Instruction::InsertElement:
case Instruction::ShuffleVector:
case Instruction::InsertValue:
+ case Instruction::BitExtract:
+ case Instruction::BitInsert:
Exp = createExpr(I);
break;
case Instruction::ICmp:
diff --git a/llvm/test/Transforms/GVN/bitextract-bitinsert.ll b/llvm/test/Transforms/GVN/bitextract-bitinsert.ll
index c33518cb701e56..75a377e7e6caaf 100644
--- a/llvm/test/Transforms/GVN/bitextract-bitinsert.ll
+++ b/llvm/test/Transforms/GVN/bitextract-bitinsert.ll
@@ -7,8 +7,7 @@ define i8 @bitextract(b32 %b) {
; CHECK-LABEL: define i8 @bitextract(
; CHECK-SAME: b32 [[B:%.*]]) {
; CHECK-NEXT: [[X:%.*]] = bitextract i8, b32 [[B]], i32 8
-; CHECK-NEXT: [[Y:%.*]] = bitextract i8, b32 [[B]], i32 8
-; CHECK-NEXT: [[R:%.*]] = add i8 [[X]], [[Y]]
+; CHECK-NEXT: [[R:%.*]] = add i8 [[X]], [[X]]
; CHECK-NEXT: ret i8 [[R]]
;
%x = bitextract i8, b32 %b, i32 8
@@ -21,8 +20,7 @@ define void @bitinsert(b32 %b, i8 %v) {
; CHECK-LABEL: define void @bitinsert(
; CHECK-SAME: b32 [[B:%.*]], i8 [[V:%.*]]) {
; CHECK-NEXT: [[X:%.*]] = bitinsert b32 [[B]], i8 [[V]], i32 8
-; CHECK-NEXT: [[Y:%.*]] = bitinsert b32 [[B]], i8 [[V]], i32 8
-; CHECK-NEXT: call void (...) @use(b32 [[X]], b32 [[Y]])
+; CHECK-NEXT: call void (...) @use(b32 [[X]], b32 [[X]])
; CHECK-NEXT: ret void
;
%x = bitinsert b32 %b, i8 %v, i32 8
@@ -106,9 +104,8 @@ define void @neg_bitinsert_offset(b32 %b, i8 %v) {
define void @bitextract_vec(<2 x b32> %b) {
; CHECK-LABEL: define void @bitextract_vec(
; CHECK-SAME: <2 x b32> [[B:%.*]]) {
-; CHECK-NEXT: [[X:%.*]] = bitextract <2 x i8>, <2 x b32> [[B]], <2 x i32> <i32 0, i32 8>
; CHECK-NEXT: [[Y:%.*]] = bitextract <2 x i8>, <2 x b32> [[B]], <2 x i32> <i32 0, i32 8>
-; CHECK-NEXT: call void (...) @use(<2 x i8> [[X]], <2 x i8> [[Y]])
+; CHECK-NEXT: call void (...) @use(<2 x i8> [[Y]], <2 x i8> [[Y]])
; CHECK-NEXT: ret void
;
%x = bitextract <2 x i8>, <2 x b32> %b, <2 x i32> <i32 0, i32 8>
More information about the llvm-branch-commits
mailing list