[llvm-branch-commits] [lldb] 2ce1a5a - Revert "Reapply "[lldb] Show synthetic children in the return value of the th…"
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Fri Nov 13 01:17:24 PST 2026
Author: Felipe de Azevedo Piovezan
Date: 2026-11-13T09:17:20Z
New Revision: 2ce1a5a48434025bfd35ca89cb1af2cc04849e65
URL: https://github.com/llvm/llvm-project/commit/2ce1a5a48434025bfd35ca89cb1af2cc04849e65
DIFF: https://github.com/llvm/llvm-project/commit/2ce1a5a48434025bfd35ca89cb1af2cc04849e65.diff
LOG: Revert "Reapply "[lldb] Show synthetic children in the return value of the th…"
This reverts commit 8de2ab5d16bcbd3f4525227abd784d0f26ae6598.
Added:
Modified:
lldb/source/Core/FormatEntity.cpp
Removed:
lldb/test/API/functionalities/return-value-synthetic/Makefile
lldb/test/API/functionalities/return-value-synthetic/TestReturnValueSynthetic.py
lldb/test/API/functionalities/return-value-synthetic/main.c
lldb/test/API/functionalities/return-value-synthetic/synthetic.py
################################################################################
diff --git a/lldb/source/Core/FormatEntity.cpp b/lldb/source/Core/FormatEntity.cpp
index 156894ba255f8..b911c4c55379a 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -14,7 +14,6 @@
#include "lldb/Core/DumpRegisterValue.h"
#include "lldb/Core/Module.h"
#include "lldb/DataFormatters/DataVisualization.h"
-#include "lldb/DataFormatters/DumpValueObjectOptions.h"
#include "lldb/DataFormatters/FormatClasses.h"
#include "lldb/DataFormatters/FormatManager.h"
#include "lldb/DataFormatters/TypeSummary.h"
@@ -1541,12 +1540,7 @@ bool FormatEntity::Formatter::Format(const Entry &entry, Stream &s,
ValueObjectSP return_valobj_sp =
StopInfo::GetReturnValueObject(stop_info_sp);
if (return_valobj_sp) {
- DumpValueObjectOptions options;
- if (return_valobj_sp->IsDynamic())
- options.SetUseDynamicType(eDynamicCanRunTarget);
- if (return_valobj_sp->DoesProvideSyntheticValue())
- options.SetUseSyntheticValue(true);
- if (llvm::Error error = return_valobj_sp->Dump(s, options)) {
+ if (llvm::Error error = return_valobj_sp->Dump(s)) {
s << "error: " << toString(std::move(error));
return false;
}
diff --git a/lldb/test/API/functionalities/return-value-synthetic/Makefile b/lldb/test/API/functionalities/return-value-synthetic/Makefile
deleted file mode 100644
index 10495940055b6..0000000000000
--- a/lldb/test/API/functionalities/return-value-synthetic/Makefile
+++ /dev/null
@@ -1,3 +0,0 @@
-C_SOURCES := main.c
-
-include Makefile.rules
diff --git a/lldb/test/API/functionalities/return-value-synthetic/TestReturnValueSynthetic.py b/lldb/test/API/functionalities/return-value-synthetic/TestReturnValueSynthetic.py
deleted file mode 100644
index 9bd105b763c0a..0000000000000
--- a/lldb/test/API/functionalities/return-value-synthetic/TestReturnValueSynthetic.py
+++ /dev/null
@@ -1,26 +0,0 @@
-"""
-Test that the return value in the thread description uses synthetic children.
-"""
-
-import os
-
-import lldb
-from lldbsuite.test.decorators import *
-from lldbsuite.test.lldbtest import *
-from lldbsuite.test import lldbutil
-
-
- at requireNotWasm("return value is unrecoverable from the operand stack at a step-out")
-class TestCase(TestBase):
- def test(self):
- self.build()
- lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("main.c"))
- self.runCmd(
- "command script import " + os.path.join(self.getSourceDir(), "synthetic.py")
- )
- self.runCmd("type synthetic add -l synthetic.PairProvider Pair")
- self.runCmd("finish")
- self.expect(
- "thread info",
- patterns=[r"Return value: \(Pair\) \$\d+ = \(second = 2\)\n"],
- )
diff --git a/lldb/test/API/functionalities/return-value-synthetic/main.c b/lldb/test/API/functionalities/return-value-synthetic/main.c
deleted file mode 100644
index 02f4e7c4f45da..0000000000000
--- a/lldb/test/API/functionalities/return-value-synthetic/main.c
+++ /dev/null
@@ -1,14 +0,0 @@
-struct Pair {
- int first;
- int second;
-};
-
-struct Pair make_pair(void) {
- struct Pair pair = {1, 2};
- return pair; // break here
-}
-
-int main(void) {
- struct Pair pair = make_pair();
- return pair.first + pair.second;
-}
diff --git a/lldb/test/API/functionalities/return-value-synthetic/synthetic.py b/lldb/test/API/functionalities/return-value-synthetic/synthetic.py
deleted file mode 100644
index 4ed1cbf72ac69..0000000000000
--- a/lldb/test/API/functionalities/return-value-synthetic/synthetic.py
+++ /dev/null
@@ -1,9 +0,0 @@
-class PairProvider:
- def __init__(self, valobj, internal_dict):
- self.valobj = valobj
-
- def num_children(self):
- return 1
-
- def get_child_at_index(self, index):
- return self.valobj.GetChildMemberWithName("second")
More information about the llvm-branch-commits
mailing list