[llvm-branch-commits] [clang] [NFC][Clang][CodeGen] Take const& in deleted copy assignment operators (PR #241713)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed Nov 11 23:02:36 PST 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-debuginfo
Author: Vitaly Buka (vitalybuka)
<details>
<summary>Changes</summary>
436f391d1d56 (#<!-- -->154671) deleted the copy assignment operators of
`ApplyInlineDebugLocation` and `SanitizerDebugLocation` with a non-const
parameter. That still leaves the classes non-copyable, but it breaks
`std::optional<SanitizerDebugLocation>`: libstdc++ fails to default the
copy assignment of its storage.
Use `const &`, matching the deleted copy constructors.
Needed by #<!-- -->241646.
Assisted-by: Gemini
---
Full diff: https://github.com/llvm/llvm-project/pull/241713.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CGDebugInfo.h (+3-2)
``````````diff
diff --git a/clang/lib/CodeGen/CGDebugInfo.h b/clang/lib/CodeGen/CGDebugInfo.h
index b70671821c920..bf92336743958 100644
--- a/clang/lib/CodeGen/CGDebugInfo.h
+++ b/clang/lib/CodeGen/CGDebugInfo.h
@@ -1028,7 +1028,8 @@ class ApplyInlineDebugLocation {
/// Restore everything back to the original state.
~ApplyInlineDebugLocation();
ApplyInlineDebugLocation(const ApplyInlineDebugLocation &) = delete;
- ApplyInlineDebugLocation &operator=(ApplyInlineDebugLocation &) = delete;
+ ApplyInlineDebugLocation &
+ operator=(const ApplyInlineDebugLocation &) = delete;
};
class SanitizerDebugLocation {
@@ -1041,7 +1042,7 @@ class SanitizerDebugLocation {
SanitizerHandler Handler);
~SanitizerDebugLocation();
SanitizerDebugLocation(const SanitizerDebugLocation &) = delete;
- SanitizerDebugLocation &operator=(SanitizerDebugLocation &) = delete;
+ SanitizerDebugLocation &operator=(const SanitizerDebugLocation &) = delete;
};
} // namespace CodeGen
``````````
</details>
https://github.com/llvm/llvm-project/pull/241713
More information about the llvm-branch-commits
mailing list